| Warnings |
|---|
| ⚠️ | Some issues found for the commit messages in this PR: - the commit message
"C2: Disable network provisioning":- type/action should start with a lowercase letter
- type/action should be one of [
change,ci,docs,feat,fix,refactor,remove,revert,test]
Please fix these commit messages - here are some basic tips: - followConventional Commits style
- correct format of commit message should be:
<type/action>(<scope/component>): <summary>, for examplefix(esp32): Fixed startup timeout issue - allowed types are:
change,ci,docs,feat,fix,refactor,remove,revert,test - sufficiently descriptive message summary should be between 10 to 72 characters and start with upper case letter
- avoid Jira references in commit messages (unavailable/irrelevant for our customers)
TIP: Install pre-commit hooks and run this check when committing (uses theConventional Precommit Linter).
|
👋Hello Jason2866, we appreciate your contribution to this project!
📘 Please review the project'sContributions Guide for key guidelines on code, documentation, testing, and more.
🖊️ Please also make sure you haveread and signed theContributor License Agreement for this project.
Click to see more instructions ...
This automated output is generated by thePR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.
DangerJS is triggered with eachpush event to a Pull Request and modify the contents of this comment.
Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger isnot a substitute for human code reviews; it's still important to request a code review from your colleagues.
-Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manuallyretry these Danger checks, please navigate to theActions tab and re-run last Danger workflow.
Review and merge process you can expect ...
We do welcome contributions in the form of bug reports, feature requests and pull requests.
1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.
Generated by 🚫dangerJS against3ac7955 |
generates weird compile issues when compiling Arduino as an component of IDF when using pioarduino. No impact on Arduino Core since no C2 precompiled libs are provided.
Trying to use wifi-provisioning with the C2 is always a bad idea keeping the low resources from the C2 in mind.
@me-no-dev as discussed in Discord