NotificationsYou must be signed in to change notification settings
Fork7.7k
Star15.1k

feat(ap): Add support for DHCP Captive Portal (opt 114)#11412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

me-no-dev merged 4 commits intomasterfromfeature/dhcp_captive_portal

Jun 4, 2025

Merged

feat(ap): Add support for DHCP Captive Portal (opt 114)#11412

me-no-dev merged 4 commits intomasterfromfeature/dhcp_captive_portal

Jun 4, 2025

Conversation

Copy link

Member

me-no-dev commentedMay 30, 2025•
edited
Loading

This pull request introduces functionality to enable a DHCP-based captive portal for WiFi access points, along with updates to simplify the setup process in the Captive Portal example. The most significant changes include adding the newenableDhcpCaptivePortal method to theAPClass, modifying the example code to utilize this new feature, and updating theWiFiAP.h header file to declare the new method.

Enhancements to WiFi Access Point functionality:

AddedenableDhcpCaptivePortal method toAPClass: This method enables a DHCP-based captive portal by configuring the DHCP server to redirect clients to a specific captive portal URI. It includes error handling for stopping and starting the DHCP server and checks if the access point is started before enabling the feature.
DeclaredenableDhcpCaptivePortal inWiFiAP.h: The new method is added to theAPClass interface, making it accessible for users of the library.

Updates to the Captive Portal example:

Simplified WiFi setup inCaptivePortal.ino: Replaced the manual configuration of the access point with the newWiFi.AP.create andWiFi.AP.enableDhcpCaptivePortal methods, streamlining the setup process for users.

Closes#11399

feat(ap): Add support for DHCP Captive Portal (opt 114)

4aa2f24

Copy link

Contributor

github-actionsbot commentedMay 30, 2025•
edited
Loading

	Messages
📖	🎉 Good Job! All checks are passing!

👋Hello me-no-dev, we appreciate your contribution to this project!

📘 Please review the project'sContributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you haveread and signed theContributor License Agreement for this project.

Click to see more instructions ...

This automated output is generated by thePR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with eachpush event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger isnot a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manuallyretry these Danger checks, please navigate to theActions tab and re-run last Danger workflow.

Review and merge process you can expect ...

We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫dangerJS against711ca88