NotificationsYou must be signed in to change notification settings
Fork7.8k
Star15.9k

HTTPUpdate: Support HTTP 204#11408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

me-no-dev merged 2 commits intoespressif:masterfromsidwarkd:patch-1

Jun 4, 2025

Merged

HTTPUpdate: Support HTTP 204#11408

me-no-dev merged 2 commits intoespressif:masterfromsidwarkd:patch-1

Jun 4, 2025

Conversation

Copy link

Contributor

sidwarkd commentedMay 29, 2025

Description of Change

HTTP 204 is a successful return code which indicates No Content. While it's appropriate to return a 304 if the server has content for a device but it hasn't change, it is more accurate for a server to return a 204 if it simply doesn't have any firmware files for a particular device.

Tests scenarios

Change is hardware independent and relies on the HTTP return code. Will work on all supported hardware. Tested on Arduino-esp32 core v3.2.0 with ESP32 Devkit C board.

Support HTTP 204

82bd09b

HTTP 204 is a successful return code which indicates No Content. While it's appropriate to return a 304 if the server has content for a device but it hasn't change, it is more accurate for a server to return a 204 if it simply doesn't have any firmware files for a particular device.

Copy link

CLAassistant commentedMay 29, 2025•
edited
Loading

All committers have signed the CLA.

Copy link

Contributor

github-actionsbot commentedMay 29, 2025•
edited
Loading

	Warnings
⚠️	Some issues found for the commit messages in this PR: the commit message`"Support HTTP 204"`: body's lines must not be longer than 100 characters summary looks empty type/action looks empty Please fix these commit messages - here are some basic tips: followConventional Commits style correct format of commit message should be:`<type/action>(<scope/component>): <summary>`, for example`fix(esp32): Fixed startup timeout issue` allowed types are:`change,ci,docs,feat,fix,refactor,remove,revert,test` sufficiently descriptive message summary should be between 10 to 72 characters and start with upper case letter avoid Jira references in commit messages (unavailable/irrelevant for our customers) `TIP:` Install pre-commit hooks and run this check when committing (uses theConventional Precommit Linter).

👋Hello sidwarkd, we appreciate your contribution to this project!

📘 Please review the project'sContributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you haveread and signed theContributor License Agreement for this project.

Click to see more instructions ...

This automated output is generated by thePR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with eachpush event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger isnot a substitute for human code reviews; it's still important to request a code review from your colleagues.
-Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manuallyretry these Danger checks, please navigate to theActions tab and re-run last Danger workflow.

Review and merge process you can expect ...

We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫dangerJS against805905d