Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(board): Alfredo-NoU3 changed default upload mode from Hardware CDC and JTAG to USB-OTG#11403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
me-no-dev merged 3 commits intoespressif:masterfromSaintSampo:master
May 27, 2025

Conversation

SaintSampo
Copy link
Contributor

Hardware CDC and JTAG with the ESP32S3 sometimes gets into a state where the only way to upload code is to first put the MCU into BOOT mode:#11327

To fix this, and now that the tiny-USB implementation on ESP32-S3 is in decent shape, upload over USB-OTG is the way to go.

@github-actionsGitHub Actions
Copy link
Contributor

github-actionsbot commentedMay 26, 2025•
edited
Loading

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message"fix(board): Alfredo-NoU3 changed default upload mode from Hardware CDC and JTAG to USB-OTG":
    • summary appears to be too long

Please fix these commit messages - here are some basic tips:

  • followConventional Commits style
  • correct format of commit message should be:<type/action>(<scope/component>): <summary>, for examplefix(esp32): Fixed startup timeout issue
  • allowed types are:change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 10 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses theConventional Precommit Linter).

👋Hello SaintSampo, we appreciate your contribution to this project!

📘 Please review the project'sContributions Guide for key guidelines on code, documentation, testing, and more.
🖊️ Please also make sure you haveread and signed theContributor License Agreement for this project.
Click to see more instructions ...


This automated output is generated by thePR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with eachpush event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger isnot a substitute for human code reviews; it's still important to request a code review from your colleagues.
-Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manuallyretry these Danger checks, please navigate to theActions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫dangerJS against78d5cec

@P-R-O-C-H-YP-R-O-C-H-Y added Type: 3rd party BoardsRelated to third-party/non-Espressif hardware boards. Status: Pending MergePull Request is ready to be merged labelsMay 26, 2025
@P-R-O-C-H-YP-R-O-C-H-Y added Status: In Progress ⚠️Issue is in progress and removed Status: Pending MergePull Request is ready to be merged labelsMay 27, 2025
@P-R-O-C-H-Y
Copy link
Member

Hi@SaintSampo, you added a new boards in last commit.
PLease revert or add all necessary changes like the variants/pins_arduino.h file for the new board and change title and description of the PR :)

@SaintSampo
Copy link
ContributorAuthor

Oops didn't mean to add that to this merge request. I thought pushing that commit would just update my fork.

P-R-O-C-H-Y reacted with thumbs up emoji

@P-R-O-C-H-YP-R-O-C-H-Y added Status: Pending MergePull Request is ready to be merged and removed Status: In Progress ⚠️Issue is in progress labelsMay 27, 2025
@P-R-O-C-H-Y
Copy link
Member

@SaintSampo The best you can do is to create a branch on your fork and commit changes to the branch. Then you can open a PR that will be coming from the branch. This way you can do multiple separate changes/PRs :)

@me-no-devme-no-dev merged commitd960f61 intoespressif:masterMay 27, 2025
13 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@P-R-O-C-H-YP-R-O-C-H-YP-R-O-C-H-Y approved these changes

Assignees
No one assigned
Labels
Status: Pending MergePull Request is ready to be mergedType: 3rd party BoardsRelated to third-party/non-Espressif hardware boards.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@SaintSampo@P-R-O-C-H-Y@me-no-dev
[8]ページ先頭
©2009-2025 Movatter.jp