Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Update gen_esp32part.py#11391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
me-no-dev merged 7 commits intomasterfromfix/gen_esp32part
May 27, 2025
Merged

Update gen_esp32part.py#11391

me-no-dev merged 7 commits intomasterfromfix/gen_esp32part
May 27, 2025

Conversation

lucasssvaz
Copy link
Collaborator

Re-submission of#11379 with proper permissions.

fromhttps://github.com/espressif/esp-idf/blob/release/v5.5/components/partition_table/gen_esp32part.py to support changes maybe done in upcoming partitions tables when using IDF 5.5 as base for Arduino

@lucasssvazlucasssvaz added the Area: Tools & Build SystemIssue is related to tools and/or the build system labelMay 22, 2025
@github-actionsGitHub Actions
Copy link
Contributor

github-actionsbot commentedMay 22, 2025
edited
Loading

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message"Update gen_esp32part.py":
    • summary looks empty
    • type/action looks empty
  • the commit message"fix flake8 (#11393)":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • followConventional Commits style
  • correct format of commit message should be:<type/action>(<scope/component>): <summary>, for examplefix(esp32): Fixed startup timeout issue
  • allowed types are:change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 10 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses theConventional Precommit Linter).

👋Hello lucasssvaz, we appreciate your contribution to this project!


📘 Please review the project'sContributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you haveread and signed theContributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by thePR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with eachpush event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger isnot a substitute for human code reviews; it's still important to request a code review from your colleagues.
-Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manuallyretry these Danger checks, please navigate to theActions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫dangerJS againste76b913

@lucasssvazlucasssvaz mentioned this pull requestMay 22, 2025
@lucasssvazlucasssvaz added the Status: Pending MergePull Request is ready to be merged labelMay 22, 2025
Copy link
CollaboratorAuthor

@lucasssvazlucasssvaz left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@Jason2866
Copy link
Collaborator

Don't have write rights in this PR. My suggestion is to change line 288 toduplicates = {n for n in names if names.count(n) > 1}

@me-no-devme-no-dev merged commitfa27597 intomasterMay 27, 2025
38 checks passed
@me-no-devme-no-dev deleted the fix/gen_esp32part branchMay 27, 2025 11:16
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@Jason2866Jason2866Jason2866 left review comments

@me-no-devme-no-devme-no-dev approved these changes

Assignees

@Jason2866Jason2866

Labels
Area: Tools & Build SystemIssue is related to tools and/or the build systemStatus: Pending MergePull Request is ready to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@lucasssvaz@Jason2866@me-no-dev

[8]ページ先頭

©2009-2025 Movatter.jp