- Notifications
You must be signed in to change notification settings - Fork7.8k
Added new Unexpected Maker SQUiXL and EDGES3[D] boards.#11350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Signed-off-by: Seon Rozenblum <seonr@3sprockets.com>
CLAassistant commentedMay 11, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
github-actionsbot commentedMay 11, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
👋Hello UnexpectedMaker, we appreciate your contribution to this project! 📘 Please review the project'sContributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you haveread and signed theContributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
Signed-off-by: Seon Rozenblum <seonr@3sprockets.com>
UnexpectedMaker commentedMay 11, 2025
It seems SQUiXL is failing your CI compile tests because it's trying to do tests with SPI - There is no SPI available to users on this board - so no SPI pins have been defined in arduino_pins.h - this is intentional, so I am not sure how to get past this issue. Is this a real blocker@me-no-dev ? Also, I've signed and confirmed the CLA - but it never changes to says I've signed. Thanks :) |
Signed-off-by: Seon Rozenblum <seon@unexpectedmaker.com>
P-R-O-C-H-Y commentedMay 12, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@UnexpectedMaker If you don't want to specify the SPI pins, you can set them as -1, but the SPI pins definition must exist :) |
UnexpectedMaker commentedMay 12, 2025
Oh, I didn't realize I could set them to -1 - I ended up adding IO assigned to them anyway :) |
P-R-O-C-H-Y left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
210edfe intoespressif:masterUh oh!
There was an error while loading.Please reload this page.
Added support for 2 of my new boards: SQUiXL and EdgeS3[D]
Both ESP32-S3 boards.
Thanks :)