Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Added new Unexpected Maker SQUiXL and EDGES3[D] boards.#11350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
me-no-dev merged 3 commits intoespressif:masterfromUnexpectedMaker:um_squixl
May 13, 2025

Conversation

@UnexpectedMaker
Copy link
Contributor

Added support for 2 of my new boards: SQUiXL and EdgeS3[D]

Both ESP32-S3 boards.

Thanks :)

Signed-off-by: Seon Rozenblum <seonr@3sprockets.com>
@CLAassistant
Copy link

CLAassistant commentedMay 11, 2025
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link
Contributor

github-actionsbot commentedMay 11, 2025
edited
Loading

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message"Added new Unexpected Maker SQUiXL and EDGES3[D] boards.":
    • summary should not end with a period (full stop)
    • summary looks empty
    • type/action looks empty
  • the commit message"Seems I have to have SPI pins defined for SQUiXL, or compiling breaks":
    • summary looks empty
    • type/action looks empty
  • the commit message"Seems we are being picky about board names now ;)":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • followConventional Commits style
  • correct format of commit message should be:<type/action>(<scope/component>): <summary>, for examplefix(esp32): Fixed startup timeout issue
  • allowed types are:change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 10 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses theConventional Precommit Linter).

👋Hello UnexpectedMaker, we appreciate your contribution to this project!


📘 Please review the project'sContributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you haveread and signed theContributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by thePR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with eachpush event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger isnot a substitute for human code reviews; it's still important to request a code review from your colleagues.
-Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manuallyretry these Danger checks, please navigate to theActions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫dangerJS againstfebd068

Signed-off-by: Seon Rozenblum <seonr@3sprockets.com>
@UnexpectedMaker
Copy link
ContributorAuthor

It seems SQUiXL is failing your CI compile tests because it's trying to do tests with SPI - There is no SPI available to users on this board - so no SPI pins have been defined in arduino_pins.h - this is intentional, so I am not sure how to get past this issue.

Is this a real blocker@me-no-dev ?

Also, I've signed and confirmed the CLA - but it never changes to says I've signed.

Thanks :)

Signed-off-by: Seon Rozenblum <seon@unexpectedmaker.com>
@P-R-O-C-H-YP-R-O-C-H-Y added the Type: 3rd party BoardsRelated to third-party/non-Espressif hardware boards. labelMay 12, 2025
@P-R-O-C-H-Y
Copy link
Member

P-R-O-C-H-Y commentedMay 12, 2025
edited
Loading

@UnexpectedMaker If you don't want to specify the SPI pins, you can set them as -1, but the SPI pins definition must exist :)
CLA seems to be fine.

@UnexpectedMaker
Copy link
ContributorAuthor

@UnexpectedMaker If you don't want to specify the SPI pins, you can set them as -1, but the SPI pins definition must exist :) CLA seems to be fine.

Oh, I didn't realize I could set them to -1 - I ended up adding IO assigned to them anyway :)

P-R-O-C-H-Y reacted with thumbs up emoji

Copy link
Member

@P-R-O-C-H-YP-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@P-R-O-C-H-YP-R-O-C-H-Y added the Status: Pending MergePull Request is ready to be merged labelMay 12, 2025
@me-no-devme-no-dev merged commit210edfe intoespressif:masterMay 13, 2025
18 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@P-R-O-C-H-YP-R-O-C-H-YP-R-O-C-H-Y approved these changes

Assignees

No one assigned

Labels

Status: Pending MergePull Request is ready to be mergedType: 3rd party BoardsRelated to third-party/non-Espressif hardware boards.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@UnexpectedMaker@CLAassistant@P-R-O-C-H-Y@me-no-dev

[8]ページ先頭

©2009-2025 Movatter.jp