This pull request makes updates to the.github/scripts/on-release.sh script to improve consistency in URL handling and correct an issue in the upload logic for Chinese-specific pages. These changes ensure proper substitution of URLs and accurate references during the upload process.

Keeping it as draft until assets like this are available:
https://dl.espressif.cn/github_assets/earlephilhower/esp-quick-toolchain/releases/download/3.0.0-gnu12/aarch64-linux-gnu.mklittlefs-c41e51a.200706.tar.gz

URL handling improvements:

Updated thesed command to simplify and generalize the substitution ofgithub.com URLs withdl.espressif.cn/github_assets by removing the hardcodedespressif path segment. This change applies to both development and release package JSON files. (.github/scripts/on-release.shL345-R350)

Upload logic corrections:

Fixed thegit_safe_upload_to_pages calls for Chinese-specific pages ($PACKAGE_JSON_DEV_CN and$PACKAGE_JSON_REL_CN) to use the correct file references, ensuring that the appropriate content is uploaded. (.github/scripts/on-release.shL459-R466)

fix(release): Replace all assets with chinese mirrors

305a73a

lucasssvaz added the Type: CI & TestingRelated to continuous integration, automated testing, or test infrastructure. label

Apr 29, 2025

lucasssvaz self-assigned this

Apr 29, 2025

Copy link

Contributor

github-actionsbot commentedApr 29, 2025•
edited
Loading

	Messages
📖	🎉 Good Job! All checks are passing!

👋Hello lucasssvaz, we appreciate your contribution to this project!

📘 Please review the project'sContributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you haveread and signed theContributor License Agreement for this project.

Click to see more instructions ...

This automated output is generated by thePR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with eachpush event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger isnot a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manuallyretry these Danger checks, please navigate to theActions tab and re-run last Danger workflow.

Review and merge process you can expect ...

We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫dangerJS againstcd06dd7

lucasssvaz marked this pull request as ready for review

April 30, 2025 16:45

lucasssvaz requested review fromme-no-dev andP-R-O-C-H-Y

April 30, 2025 16:46

lucasssvaz added the Status: Review neededIssue or PR is awaiting review label

Apr 30, 2025

feat(release): Add script to append "-cn" to versions

c840037

lucasssvaz requested review frompedrominatel andSuGlider

May 14, 2025 10:56

lucasssvaz added the Type: DocumentationIssue pertains to Documentation of Arduino ESP32 label

May 14, 2025

P-R-O-C-H-Y requested a review fromCopilot

May 14, 2025 11:20

CopilotAI reviewed

May 14, 2025

View reviewed changes

Copy link

Contributor

CopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR updates our release process to use Chinese mirror assets and corrects the upload logic for Chinese-specific package files. The changes include:

A more generic sed URL substitution in on-release.sh for both development and release package files.
The addition of release_append_cn.py to append a “-cn” suffix to version strings.
Updates to the installation documentation to guide Chinese users on manual updates.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
docs/en/installing.rst	Updated instructions for Chinese users regarding package updates.
.github/scripts/release_append_cn.py	New script to append "-cn" to version strings in package JSONs.
.github/scripts/on-release.sh	Modified URL substitutions and upload calls to correctly refer to Chinese mirrors.

Comments suppressed due to low confidence (2)

.github/scripts/on-release.sh:345

The updated sed command now applies a generic replacement for URLs; please ensure that this pattern does not unintentionally modify URL segments in contexts where only selective substitution is desired.

sed '0,/github\.com\//!s|github\.com/|dl.espressif.cn/github_assets/|g' "$OUTPUT_DIR/$PACKAGE_JSON_DEV" > "$OUTPUT_DIR/$PACKAGE_JSON_DEV_CN"

.github/scripts/release_append_cn.py:21

[nitpick] The early return for objects with name 'dfu-util' effectively skips version modifications; consider verifying that no nested version entries under 'dfu-util' require appending the '-cn' suffix.