Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Restore proper pin remapping functionality after 3.2.0#11315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

pillo79
Copy link
Contributor

Issue reported at the Arduino Forums inthis thread.

Commit0773dd7 from PR#10841 broke pin remapping by moving its application too early in the definition process. This commit restores the original order of includes, ensuring that pin remapping is applied correctly.

per1234 reacted with heart emoji
Commit0773dd7 from PRespressif#10841 broke pinremapping by moving its application too early in the definition process.This commit restores the original order of includes, ensuring that pinremapping is applied correctly.Signed-off-by: Luca Burelli <l.burelli@arduino.cc>
@github-actionsGitHub Actions
Copy link
Contributor

github-actionsbot commentedApr 28, 2025
edited
Loading

Messages
📖🎉 Good Job! All checks are passing!

👋Hello pillo79, we appreciate your contribution to this project!


📘 Please review the project'sContributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you haveread and signed theContributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by thePR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with eachpush event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger isnot a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manuallyretry these Danger checks, please navigate to theActions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫dangerJS againstf34a256

@github-actionsGitHub Actions
Copy link
Contributor

github-actionsbot commentedApr 28, 2025
edited
Loading

Test Results

 76 files   76 suites   12m 42s ⏱️
 38 tests  38 ✅ 0 💤 0 ❌
241 runs  241 ✅ 0 💤 0 ❌

Results for commitf34a256.

♻️ This comment has been updated with latest results.

@SuGliderSuGlider self-requested a reviewApril 28, 2025 15:35
@SuGlider
Copy link
Collaborator

@pillo79 - thanks for the PR. Just let me check if it work with the#10841 use case.

pillo79 reacted with thumbs up emoji

@SuGlider
Copy link
Collaborator

@pillo79 - thanks for the PR. Just let me check if it work with the#10841 use case.

All good. LGTM for merging.

pillo79 reacted with rocket emoji

@me-no-devme-no-dev merged commit16fcdeb intoespressif:masterApr 29, 2025
57 checks passed
@pillo79pillo79 deleted the pr-fix-3.2.0-pin-remapping branchApril 29, 2025 07:17
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@me-no-devme-no-devme-no-dev approved these changes

@SuGliderSuGliderSuGlider approved these changes

Assignees
No one assigned
Labels
Status: Pending MergePull Request is ready to be merged
Projects
Milestone
3.2.1
Development

Successfully merging this pull request may close these issues.

3 participants
@pillo79@SuGlider@me-no-dev

[8]ページ先頭

©2009-2025 Movatter.jp