Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(esp32): Zigbee power outlet example#11296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
me-no-dev merged 9 commits intoespressif:masterfromlboue:zigbee-power-outlet
May 27, 2025

Conversation

lboue
Copy link
Contributor

@lbouelboue commentedApr 24, 2025
edited
Loading

Checklist

  1. Please provide specific title of the PR describing the change, including the component name (eg. „Update of Documentation link on Readme.md“)
  2. Please provide related links (eg. Issue which will be closed by this Pull Request)
  3. Pleaseupdate relevant Documentation if applicable
  4. Please checkContributing guide
  5. Pleaseconfirm option to "Allow edits and access to secrets by maintainers" when opening a Pull Request

Description of Change

Add Zigbee power outlet example (ESP_ZB_HA_MAINS_POWER_OUTLET_DEVICE_ID device type)

Tests scenarios

I have tested my Pull Request on Arduino-esp32 core v3.2.0 with ESP32-C6 Board with this scenario)

Tested with Zigbee2MQTT
image

image

Related links

Please provide links to related issue, PRs etc.

@github-actionsGitHub Actions
Copy link
Contributor

github-actionsbot commentedApr 24, 2025
edited
Loading

Messages
📖🎉 Good Job! All checks are passing!

👋Hello lboue, we appreciate your contribution to this project!


📘 Please review the project'sContributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you haveread and signed theContributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by thePR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with eachpush event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger isnot a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manuallyretry these Danger checks, please navigate to theActions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫dangerJS againsta4db024

@lbouelboue marked this pull request as ready for reviewApril 24, 2025 19:31
@github-actionsGitHub Actions
Copy link
Contributor

github-actionsbot commentedApr 24, 2025
edited
Loading

Test Results

 76 files   76 suites   12m 46s ⏱️
 38 tests  38 ✅ 0 💤 0 ❌
241 runs  241 ✅ 0 💤 0 ❌

Results for commita4db024.

♻️ This comment has been updated with latest results.

@github-actionsGitHub Actions
Copy link
Contributor

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32S30⚠️ +1680.00⚠️ +0.03000.000.00
ESP32S20⚠️ +1680.00⚠️ +0.03000.000.00
ESP32C3000.000.00000.000.00
ESP32C6000.000.00000.000.00
ESP32H2000.000.00000.000.00
ESP320⚠️ +1680.00⚠️ +0.03000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32S3ESP32S2ESP32C3ESP32C6ESP32H2ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
libraries/Zigbee/examples/Zigbee_Color_Dimmer_Switch⚠️ +1680⚠️ +1680000000⚠️ +1680
libraries/Zigbee/examples/Zigbee_Gateway⚠️ +1680⚠️ +168000----⚠️ +1680
libraries/Zigbee/examples/Zigbee_On_Off_Switch⚠️ +1680⚠️ +1680000000⚠️ +1680
libraries/Zigbee/examples/Zigbee_Range_Extender⚠️ +1680⚠️ +1680000000⚠️ +1680
libraries/Zigbee/examples/Zigbee_Thermostat⚠️ +1680⚠️ +1680000000⚠️ +1680
libraries/Zigbee/examples/Zigbee_Analog_Input_Output------0000--
libraries/Zigbee/examples/Zigbee_CarbonDioxide_Sensor------0000--
libraries/Zigbee/examples/Zigbee_Color_Dimmable_Light------0000--
libraries/Zigbee/examples/Zigbee_Contact_Switch------0000--
libraries/Zigbee/examples/Zigbee_Dimmable_Light------0000--
libraries/Zigbee/examples/Zigbee_Illuminance_Sensor------0000--
libraries/Zigbee/examples/Zigbee_OTA_Client------0000--
libraries/Zigbee/examples/Zigbee_Occupancy_Sensor------0000--
libraries/Zigbee/examples/Zigbee_On_Off_Light------0000--
libraries/Zigbee/examples/Zigbee_PM25_Sensor------0000--
libraries/Zigbee/examples/Zigbee_Power_Outlet------------
libraries/Zigbee/examples/Zigbee_Pressure_Flow_Sensor------0000--
libraries/Zigbee/examples/Zigbee_Scan_Networks------0000--
libraries/Zigbee/examples/Zigbee_Temp_Hum_Sensor_Sleepy------0000--
libraries/Zigbee/examples/Zigbee_Temperature_Sensor------0000--
libraries/Zigbee/examples/Zigbee_Vibration_Sensor------0000--
libraries/Zigbee/examples/Zigbee_Wind_Speed_Sensor------0000--
libraries/Zigbee/examples/Zigbee_Window_Covering------0000--

@lucasssvazlucasssvaz added the Area: ZigbeeIssues and Feature Request about Zigbee labelApr 24, 2025
@lucasssvaz
Copy link
Collaborator

There is also a compilation warning:

https://github.com/espressif/arduino-esp32/actions/runs/14650359254/job/41114439256?pr=11296#step:8:128

Is this fixable in the code or does it come for the Zigbee SDK ?

@lboue
Copy link
ContributorAuthor

lboue commentedApr 25, 2025
edited
Loading

There is also a compilation warning:

https://github.com/espressif/arduino-esp32/actions/runs/14650359254/job/41114439256?pr=11296#step:8:128

Is this fixable in the code or does it come for the Zigbee SDK ?

Yes it comes for the Zigbee SDK because I am not using groups, scenes like in the ZigbeeLight.cpp example:

warning: missing initializer for member 'esp_zb_mains_power_outlet_cfg_s::groups_cfg' [-Wmissing-field-initializers]warning: missing initializer for member 'esp_zb_mains_power_outlet_cfg_s::scenes_cfg' [-Wmissing-field-initializers]warning: missing initializer for member 'esp_zb_mains_power_outlet_cfg_s::on_off_cfg' [-Wmissing-field-initializers]

@lbouelboue requested a review fromlucasssvazApril 25, 2025 11:33
@P-R-O-C-H-Y
Copy link
Member

There is also a compilation warning:
https://github.com/espressif/arduino-esp32/actions/runs/14650359254/job/41114439256?pr=11296#step:8:128
Is this fixable in the code or does it come for the Zigbee SDK ?

Yes it comes for the Zigbee SDK because I am not using groups, scenes like in the ZigbeeLight.cpp example:

warning: missing initializer for member 'esp_zb_mains_power_outlet_cfg_s::groups_cfg' [-Wmissing-field-initializers]warning: missing initializer for member 'esp_zb_mains_power_outlet_cfg_s::scenes_cfg' [-Wmissing-field-initializers]warning: missing initializer for member 'esp_zb_mains_power_outlet_cfg_s::on_off_cfg' [-Wmissing-field-initializers]

I think we should add the groups, scenes, etc to fix this warning. I will take a look and check the best solution :)
Anyways thanks for adding new endpoint type :)

@P-R-O-C-H-YP-R-O-C-H-Y added the Status: In Progress ⚠️Issue is in progress labelApr 25, 2025
@P-R-O-C-H-YP-R-O-C-H-Y self-assigned thisApr 30, 2025
@P-R-O-C-H-YP-R-O-C-H-Y added Status: Review neededIssue or PR is awaiting review and removed Status: In Progress ⚠️Issue is in progress labelsMay 12, 2025
@P-R-O-C-H-YP-R-O-C-H-Y added Status: Pending MergePull Request is ready to be merged and removed Status: Review neededIssue or PR is awaiting review labelsMay 23, 2025
@me-no-devme-no-dev merged commit9090b46 intoespressif:masterMay 27, 2025
56 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@lucasssvazlucasssvazlucasssvaz approved these changes

@P-R-O-C-H-YP-R-O-C-H-YP-R-O-C-H-Y approved these changes

@me-no-devme-no-devAwaiting requested review from me-no-devme-no-dev is a code owner

Assignees

@P-R-O-C-H-YP-R-O-C-H-Y

Labels
Area: ZigbeeIssues and Feature Request about ZigbeeStatus: Pending MergePull Request is ready to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@lboue@lucasssvaz@P-R-O-C-H-Y@me-no-dev

[8]ページ先頭

©2009-2025 Movatter.jp