Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(rmt): fixes example to run correctly within IDF 5.x#11292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
me-no-dev merged 2 commits intomasterfromfix/rmt_blink_example
Apr 28, 2025

Conversation

SuGlider
Copy link
Collaborator

Description of Change

This example crashes when running with the ESP32 because it doesn't supportSOC_RMT_SUPPORT_TX_LOOP_AUTO_STOP feature. All other SoC were running the example correctly.

The timming was also incorrect becuase it was sending one RMT Symbol less.

This PR fixes the example to run with no crashes for all the SoC supported by Arduino Core 3.2.x+
It also fixes the blink timming as verified by a logic analizer.

Tests scenarios

Tested using the example with ESP32, S2, S3, C3 and C6.

Related links

Closes#11281

@SuGliderSuGlider added Area: LibrariesIssue is related to Library support. Type: ExampleIssue is related to specific example. labelsApr 24, 2025
@SuGliderSuGlider added this to the3.2.1 milestoneApr 24, 2025
@SuGliderSuGlider self-assigned thisApr 24, 2025
@github-actionsGitHub Actions
Copy link
Contributor

github-actionsbot commentedApr 24, 2025
edited
Loading

Messages
📖🎉 Good Job! All checks are passing!

👋Hello SuGlider, we appreciate your contribution to this project!


📘 Please review the project'sContributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you haveread and signed theContributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by thePR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with eachpush event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger isnot a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manuallyretry these Danger checks, please navigate to theActions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫dangerJS against0aa6a34

@github-actionsGitHub Actions
Copy link
Contributor

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32P4💚 -1000.000.00000.000.00
ESP32S30⚠️ +40.000.00000.000.00
ESP32S2💚 -400.000.00000.000.00
ESP32C3💚 -1200.000.00000.000.00
ESP32C6💚 -1000.000.00000.000.00
ESP32H2💚 -1000.000.00000.000.00
ESP32💚 -1200.000.00000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32P4ESP32S3ESP32S2ESP32C3ESP32C6ESP32H2ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
libraries/ESP32/examples/RMT/RMT_LED_Blink💚 -100⚠️ +40💚 -40💚 -120💚 -100💚 -100💚 -120

@SuGliderSuGlider changed the titlefeat(rmt): fixes exaple to run correctly within IDF 5.xfeat(rmt): fixes example to run correctly within IDF 5.xApr 24, 2025
@SuGliderSuGlider added the Status: Review neededIssue or PR is awaiting review labelApr 24, 2025
@SuGliderSuGlider moved this fromIn Progress toIn Review inArduino ESP32 Core Project RoadmapApr 24, 2025
@SuGliderSuGlider added Status: Pending MergePull Request is ready to be merged and removed Status: Review neededIssue or PR is awaiting review labelsApr 24, 2025
@me-no-devme-no-dev merged commit8d121e0 intomasterApr 28, 2025
21 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@lucasssvazlucasssvazlucasssvaz approved these changes

@P-R-O-C-H-YP-R-O-C-H-YP-R-O-C-H-Y approved these changes

@me-no-devme-no-devAwaiting requested review from me-no-dev

Assignees

@SuGliderSuGlider

Labels
Area: LibrariesIssue is related to Library support.Status: Pending MergePull Request is ready to be mergedType: ExampleIssue is related to specific example.
Projects
Milestone
3.2.1
Development

Successfully merging this pull request may close these issues.

RMT standard example RMT_LED_Blink crashes
4 participants
@SuGlider@lucasssvaz@P-R-O-C-H-Y@me-no-dev

[8]ページ先頭

©2009-2025 Movatter.jp