NotificationsYou must be signed in to change notification settings
Fork7.7k
Star15.1k

ci(release): Add package JSON with chinese mirrors#11288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

me-no-dev merged 2 commits intoespressif:masterfromlucasssvaz:ci/add_cn_json

Apr 28, 2025

Merged

ci(release): Add package JSON with chinese mirrors#11288

me-no-dev merged 2 commits intoespressif:masterfromlucasssvaz:ci/add_cn_json

Apr 28, 2025

Conversation

Copy link

Collaborator

lucasssvaz commentedApr 23, 2025

Description of Change

This pull request enhances the release script (.github/scripts/on-release.sh) to support generating and handling package JSON files for a Chinese mirror (dl.espressif.cn). The changes ensure compatibility with the Chinese mirror by adding new JSON files, modifying commands, and updating upload logic.

Support for Chinese mirror:

Added new variablesPACKAGE_JSON_DEV_CN andPACKAGE_JSON_REL_CN to handle Chinese mirror-specific package JSON files.
Updated thesed command to replace URLs for the Chinese mirror (github.com →dl.espressif.cn/github_assets) while generating the Chinese-specific JSON files.
Modified themerge_package_json logic to include merging of Chinese mirror-specific JSON files during release preparation.
Added a note that package JSONs for the Chinese mirror are not tested during the release process, as the mirror might not yet be updated.
Enhanced the upload steps to include uploading the Chinese mirror-specific JSON files to both GitHub assets and GitHub Pages.

ci(release): Add package JSON with chinese mirrors

7004781

lucasssvaz added the Type: CI & TestingRelated to continuous integration, automated testing, or test infrastructure. label

Apr 23, 2025

lucasssvaz requested a review fromme-no-dev

April 23, 2025 18:36

lucasssvaz self-assigned this

Apr 23, 2025

Copy link

Contributor

github-actionsbot commentedApr 23, 2025•
edited
Loading

	Messages
📖	🎉 Good Job! All checks are passing!

👋Hello lucasssvaz, we appreciate your contribution to this project!

📘 Please review the project'sContributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you haveread and signed theContributor License Agreement for this project.

Click to see more instructions ...

This automated output is generated by thePR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with eachpush event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger isnot a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manuallyretry these Danger checks, please navigate to theActions tab and re-run last Danger workflow.

Review and merge process you can expect ...

We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫dangerJS against1dad781