Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(uart): sets correct ESP32/S2 clock source for the example#11286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
me-no-dev merged 2 commits intomasterfromuart_clk_src_rx_timeout_example
Apr 23, 2025

Conversation

SuGlider
Copy link
Collaborator

@SuGliderSuGlider commentedApr 23, 2025
edited
Loading

Description of Change

Rx Timeout example was not working correctly using ESP32 and ESP32-S2 due to default selection of REF_TICK as UART Clock Source. REF_TICK limits RX Timeout to 1.

This PR adds the necessary call toHardwareSerial::setClockSource() in order to make it work properly.

Tests scenarios

Tested using the example code of this PR.
ESP32 | ESP32-S2 | ESP32-C3 | ESP32-C6 | ESP32-S3 | ESP32-H2

Expect output (see the time it takes to read 10 bytes):

ets Jul 29 2019 12:21:46rst:0x1 (POWERON_RESET),boot:0x13 (SPI_FAST_FLASH_BOOT)configsip: 0, SPIWP:0xeeclk_drv:0x00,q_drv:0x00,d_drv:0x00,cs0_drv:0x00,hd_drv:0x00,wp_drv:0x00mode:DIO, clock div:1load:0x3fff0030,len:4888load:0x40078000,len:16516load:0x40080400,len:4load:0x40080404,len:3476entry 0x400805b4[     8][I][esp32-hal-psram.c:102] psramAddToHeap(): PSRAM added to the heap.================================Test Case #1================================Testing the time for receiving 10 bytes at 9600 baud, using RX Timeout = 50:It has sent 10 bytes from Serial1 TX to Serial1 RXIt took 62 milliseconds to read 10 bytesReceived data: [0123456789]========================Finished!================================Test Case #2================================Testing the time for receiving 10 bytes at 9600 baud, using RX Timeout = 20:It has sent 10 bytes from Serial1 TX to Serial1 RXIt took 31 milliseconds to read 10 bytesReceived data: [0123456789]========================Finished!================================Test Case #3================================Testing the time for receiving 10 bytes at 9600 baud, using RX Timeout = 10:It has sent 10 bytes from Serial1 TX to Serial1 RXIt took 21 milliseconds to read 10 bytesReceived data: [0123456789]========================Finished!================================Test Case #4================================Testing the time for receiving 10 bytes at 9600 baud, using RX Timeout = 5:It has sent 10 bytes from Serial1 TX to Serial1 RXIt took 16 milliseconds to read 10 bytesReceived data: [0123456789]========================Finished!================================Test Case #5================================Testing the time for receiving 10 bytes at 9600 baud, using RX Timeout = 1:It has sent 10 bytes from Serial1 TX to Serial1 RXIt took 11 milliseconds to read 10 bytesReceived data: [0123456789]========================Finished!

Related links

None

@SuGliderSuGlider added the Peripheral: UARTRelated to the UART peripheral or its functionality. labelApr 23, 2025
@SuGliderSuGlider added this to the3.2.1 milestoneApr 23, 2025
@SuGliderSuGlider self-assigned thisApr 23, 2025
@SuGliderSuGlider moved this fromTodo toIn Progress inArduino ESP32 Core Project RoadmapApr 23, 2025
@github-actionsGitHub Actions
Copy link
Contributor

github-actionsbot commentedApr 23, 2025
edited
Loading

Messages
📖🎉 Good Job! All checks are passing!

👋Hello SuGlider, we appreciate your contribution to this project!


📘 Please review the project'sContributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you haveread and signed theContributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by thePR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with eachpush event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger isnot a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manuallyretry these Danger checks, please navigate to theActions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫dangerJS against4b975f9

@github-actionsGitHub Actions
Copy link
Contributor

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32P4000.000.00000.000.00
ESP32S3000.000.00000.000.00
ESP32S20⚠️ +640.00⚠️ +0.02000.000.00
ESP32C3000.000.00000.000.00
ESP32C6000.000.00000.000.00
ESP32H2000.000.00000.000.00
ESP320⚠️ +760.00⚠️ +0.02000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32P4ESP32S3ESP32S2ESP32C3ESP32C6ESP32H2ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
libraries/ESP32/examples/Serial/RxTimeout_Demo0000⚠️ +640000000⚠️ +760

@SuGliderSuGlider moved this fromIn Progress toIn Review inArduino ESP32 Core Project RoadmapApr 23, 2025
@SuGliderSuGlider added the Status: Review neededIssue or PR is awaiting review labelApr 23, 2025
@lucasssvaz
Copy link
Collaborator

Do you think this could be adapted as a test case in our UART CI test ?

@me-no-devme-no-dev added Status: Pending MergePull Request is ready to be merged and removed Status: Review neededIssue or PR is awaiting review labelsApr 23, 2025
@me-no-devme-no-dev merged commit571c2f7 intomasterApr 23, 2025
21 checks passed
@me-no-devme-no-dev deleted the uart_clk_src_rx_timeout_example branchApril 23, 2025 17:20
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@me-no-devme-no-devme-no-dev approved these changes

@lucasssvazlucasssvazlucasssvaz approved these changes

@P-R-O-C-H-YP-R-O-C-H-YAwaiting requested review from P-R-O-C-H-Y

Assignees

@SuGliderSuGlider

Labels
Peripheral: UARTRelated to the UART peripheral or its functionality.Status: Pending MergePull Request is ready to be merged
Projects
Milestone
3.2.1
Development

Successfully merging this pull request may close these issues.

3 participants
@SuGlider@lucasssvaz@me-no-dev

[8]ページ先頭

©2009-2025 Movatter.jp