Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

docs(language): Enforce English on contributions and issues#11267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
me-no-dev merged 1 commit intoespressif:masterfromlucasssvaz:docs/eng
Apr 22, 2025

Conversation

lucasssvaz
Copy link
Collaborator

This pull request introduces updates to enforce English as the standard language for communication in feature requests, issue reports, and contributions. These changes aim to ensure effective communication and streamline the review process.

Updates to communication guidelines:

Updates to contribution guidelines:

  • docs/en/contributing.rst: Introduced a new guideline stating that all contributions, including pull requests, must be written in English. Contributions in other languages will be closed with a request for re-submission in English.

@lucasssvazlucasssvaz added the Type: DocumentationIssue pertains to Documentation of Arduino ESP32 labelApr 21, 2025
@lucasssvazlucasssvaz self-assigned thisApr 21, 2025
@github-actionsGitHub Actions
Copy link
Contributor

Messages
📖🎉 Good Job! All checks are passing!

👋Hello lucasssvaz, we appreciate your contribution to this project!


📘 Please review the project'sContributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you haveread and signed theContributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by thePR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with eachpush event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger isnot a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manuallyretry these Danger checks, please navigate to theActions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫dangerJS against0741e27

@lucasssvazlucasssvaz added the Status: Review neededIssue or PR is awaiting review labelApr 21, 2025
Copy link
Member

@pedrominatelpedrominatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@me-no-devme-no-dev added Status: Pending MergePull Request is ready to be merged and removed Status: Review neededIssue or PR is awaiting review labelsApr 22, 2025
@me-no-devme-no-dev merged commitc110ca8 intoespressif:masterApr 22, 2025
20 checks passed
@lucasssvazlucasssvaz deleted the docs/eng branchApril 23, 2025 11:48
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@pedrominatelpedrominatelpedrominatel approved these changes

@me-no-devme-no-devme-no-dev approved these changes

@P-R-O-C-H-YP-R-O-C-H-YP-R-O-C-H-Y approved these changes

Assignees

@lucasssvazlucasssvaz

Labels
Status: Pending MergePull Request is ready to be mergedType: DocumentationIssue pertains to Documentation of Arduino ESP32
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@lucasssvaz@pedrominatel@me-no-dev@P-R-O-C-H-Y

[8]ページ先頭

©2009-2025 Movatter.jp