Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(zigbee): Add Occupancy sensor type and configuration#11246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
P-R-O-C-H-Y wants to merge5 commits intoespressif:master
base:master
Choose a base branch
Loading
fromP-R-O-C-H-Y:feat/zigbee-occupancy-sensor-config

Conversation

@P-R-O-C-H-Y
Copy link
Member

@P-R-O-C-H-YP-R-O-C-H-Y commentedApr 14, 2025
edited
Loading

Description of Change

This PR adds configuration of Occupancy sensor, which enabled setting sensor type, delays and threshold.

Tests scenarios

To be tested with HA when configuration is available and I receive HW.

Related links

@github-actions
Copy link
Contributor

github-actionsbot commentedApr 14, 2025
edited
Loading

Messages
📖🎉 Good Job! All checks are passing!

👋Hello P-R-O-C-H-Y, we appreciate your contribution to this project!


📘 Please review the project'sContributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you haveread and signed theContributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by thePR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with eachpush event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger isnot a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manuallyretry these Danger checks, please navigate to theActions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫dangerJS against59ab55e

@P-R-O-C-H-YP-R-O-C-H-Yforce-pushed thefeat/zigbee-occupancy-sensor-config branch fromdd1d3b8 toff76843CompareApril 14, 2025 10:38
@P-R-O-C-H-YP-R-O-C-H-Y self-assigned thisApr 14, 2025
@P-R-O-C-H-YP-R-O-C-H-Y added the Area: ZigbeeIssues and Feature Request about Zigbee labelApr 14, 2025
@P-R-O-C-H-YP-R-O-C-H-Y changed the titlefeat(zigbee): Add sensor type and configurationfeat(zigbee): Add Occupancy sensor type and configurationApr 14, 2025
@github-actions
Copy link
Contributor

github-actionsbot commentedApr 14, 2025
edited
Loading

Test Results

 76 files   76 suites   12m 46s ⏱️
 38 tests  38 ✅ 0 💤 0 ❌
241 runs  241 ✅ 0 💤 0 ❌

Results for commit59ab55e.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32S30⚠️ +1360.00⚠️ +0.02000.000.00
ESP32S20⚠️ +1360.00⚠️ +0.02000.000.00
ESP32C3000.000.00000.000.00
ESP32C6💚 -10⚠️ +19740.00⚠️ +0.350⚠️ +160.00⚠️ +0.06
ESP32H2💚 -10⚠️ +19780.00⚠️ +0.350⚠️ +320.00⚠️ +0.11
ESP320⚠️ +1240.00⚠️ +0.02000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32S3ESP32S2ESP32C3ESP32C6ESP32H2ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
libraries/Zigbee/examples/Zigbee_Color_Dimmer_Switch⚠️ +1360⚠️ +136000💚 -100💚 -100⚠️ +1200
libraries/Zigbee/examples/Zigbee_Gateway⚠️ +1360⚠️ +136000----⚠️ +1240
libraries/Zigbee/examples/Zigbee_On_Off_Switch⚠️ +1360⚠️ +136000💚 -100💚 -100⚠️ +1240
libraries/Zigbee/examples/Zigbee_Range_Extender⚠️ +1360⚠️ +136000💚 -100💚 -100⚠️ +1240
libraries/Zigbee/examples/Zigbee_Thermostat⚠️ +1360⚠️ +136000💚 -100💚 -100⚠️ +1240
libraries/Zigbee/examples/Zigbee_Analog_Input_Output------💚 -100💚 -100--
libraries/Zigbee/examples/Zigbee_CarbonDioxide_Sensor------💚 -100💚 -100--
libraries/Zigbee/examples/Zigbee_Color_Dimmable_Light------💚 -100💚 -100--
libraries/Zigbee/examples/Zigbee_Contact_Switch------💚 -100💚 -100--
libraries/Zigbee/examples/Zigbee_Dimmable_Light------💚 -100💚 -100--
libraries/Zigbee/examples/Zigbee_Illuminance_Sensor------💚 -100💚 -100--
libraries/Zigbee/examples/Zigbee_OTA_Client------💚 -100💚 -100--
libraries/Zigbee/examples/Zigbee_Occupancy_Sensor------⚠️ +1974⚠️ +16⚠️ +1978⚠️ +32--
libraries/Zigbee/examples/Zigbee_On_Off_Light------💚 -100💚 -100--
libraries/Zigbee/examples/Zigbee_PM25_Sensor------💚 -100💚 -100--
libraries/Zigbee/examples/Zigbee_Pressure_Flow_Sensor------💚 -100💚 -100--
libraries/Zigbee/examples/Zigbee_Scan_Networks------💚 -100💚 -100--
libraries/Zigbee/examples/Zigbee_Temp_Hum_Sensor_Sleepy------💚 -100💚 -100--
libraries/Zigbee/examples/Zigbee_Temperature_Sensor------💚 -100💚 -100--
libraries/Zigbee/examples/Zigbee_Vibration_Sensor------💚 -100💚 -100--
libraries/Zigbee/examples/Zigbee_Wind_Speed_Sensor------💚 -100💚 -100--
libraries/Zigbee/examples/Zigbee_Window_Covering------💚 -100💚 -100--

@lboue
Copy link
Contributor

Is it ready to merge?

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

@P-R-O-C-H-YP-R-O-C-H-Y

Labels

Area: ZigbeeIssues and Feature Request about Zigbee

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@P-R-O-C-H-Y@lboue

[8]ページ先頭

©2009-2025 Movatter.jp