Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(usb_hid): duplicated CONSUMER_CONTROL_PLAY_PAUSE#11242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
me-no-dev merged 1 commit intomasterfromusb_hid_consumer
Apr 14, 2025

Conversation

SuGlider
Copy link
Collaborator

Description of Change

CONSUMER_CONTROL_PLAY_PAUSE is defined in line 40 & 48

Tests scenarios

CI only

Related links

#11227 (review)

@github-actionsGitHub Actions
Copy link
Contributor

Messages
📖🎉 Good Job! All checks are passing!

👋Hello SuGlider, we appreciate your contribution to this project!


📘 Please review the project'sContributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you haveread and signed theContributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by thePR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with eachpush event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger isnot a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manuallyretry these Danger checks, please navigate to theActions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫dangerJS against7abcee2

@github-actionsGitHub Actions
Copy link
Contributor

github-actionsbot commentedApr 13, 2025
edited
Loading

Test Results

 76 files   76 suites   12m 43s ⏱️
 38 tests  38 ✅ 0 💤 0 ❌
241 runs  241 ✅ 0 💤 0 ❌

Results for commit7abcee2.

♻️ This comment has been updated with latest results.

@github-actionsGitHub Actions
Copy link
Contributor

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32P4000.000.00000.000.00
ESP32S3000.000.00000.000.00
ESP32S2000.000.00000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32P4ESP32S3ESP32S2
ExampleFLASHRAMFLASHRAMFLASHRAM
libraries/USB/examples/CompositeDevice000000
libraries/USB/examples/ConsumerControl000000
libraries/USB/examples/CustomHIDDevice000000
libraries/USB/examples/FirmwareMSC000000
libraries/USB/examples/Gamepad000000
libraries/USB/examples/HIDVendor000000
libraries/USB/examples/Keyboard/KeyboardLogout000000
libraries/USB/examples/Keyboard/KeyboardMessage000000
libraries/USB/examples/Keyboard/KeyboardReprogram000000
libraries/USB/examples/Keyboard/KeyboardSerial000000
libraries/USB/examples/KeyboardAndMouseControl000000
libraries/USB/examples/MIDI/MidiController000000
libraries/USB/examples/MIDI/MidiInterface000000
libraries/USB/examples/MIDI/MidiMusicBox000000
libraries/USB/examples/MIDI/ReceiveMidi000000
libraries/USB/examples/Mouse/ButtonMouseControl000000
libraries/USB/examples/SystemControl000000
libraries/USB/examples/USBMSC000000
libraries/USB/examples/USBSerial000000
libraries/USB/examples/USBVendor000000

@P-R-O-C-H-YP-R-O-C-H-Y added Status: Pending MergePull Request is ready to be merged and removed Status: Review neededIssue or PR is awaiting review labelsApr 14, 2025
@me-no-devme-no-dev merged commit3fcc316 intomasterApr 14, 2025
77 of 86 checks passed
@SuGliderSuGlider deleted the usb_hid_consumer branchApril 20, 2025 01:23
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@me-no-devme-no-devme-no-dev approved these changes

@lucasssvazlucasssvazlucasssvaz approved these changes

@P-R-O-C-H-YP-R-O-C-H-YP-R-O-C-H-Y approved these changes

Assignees

@SuGliderSuGlider

Labels
Area: Peripherals APIRelates to peripheral's APIs.Status: Pending MergePull Request is ready to be merged
Projects
Milestone
3.2.1
Development

Successfully merging this pull request may close these issues.

4 participants
@SuGlider@me-no-dev@lucasssvaz@P-R-O-C-H-Y

[8]ページ先頭

©2009-2025 Movatter.jp