- Notifications
You must be signed in to change notification settings - Fork7.7k
fix(wifi): Workaround bug in esp_wifi_get_protocol()#11239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
github-actionsbot commentedApr 11, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
👋Hello me-no-dev, we appreciate your contribution to this project! 📘 Please review the project'sContributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you haveread and signed theContributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
github-actionsbot commentedApr 11, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Test Results 76 files 76 suites 13m 29s ⏱️ Results for commite65dd57. ♻️ This comment has been updated with latest results. |
f122366
intomasterUh oh!
There was an error while loading.Please reload this page.
This pull request includes changes to the
WiFiGenericClass::mode
method in theWiFiGeneric.cpp
file. The changes involve updating the data type of thecurrent_protocol
variable and modifying the way its address is passed to theesp_wifi_get_protocol
function. This is required, becauseesp_wifi_get_protocol
sets more than one byte in the provided return mask.Data type and casting updates:
current_protocol
fromuint8_t
touint32_t
to accommodate a wider range of values.esp_wifi_get_protocol
function calls to cast the address ofcurrent_protocol
touint8_t*
to match the expected parameter type.[1][2]Fixes:#11218