Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(wifi): Workaround bug in esp_wifi_get_protocol()#11239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
me-no-dev merged 2 commits intomasterfromme-no-dev-patch-1
Apr 14, 2025

Conversation

me-no-dev
Copy link
Member

This pull request includes changes to theWiFiGenericClass::mode method in theWiFiGeneric.cpp file. The changes involve updating the data type of thecurrent_protocol variable and modifying the way its address is passed to theesp_wifi_get_protocol function. This is required, becauseesp_wifi_get_protocol sets more than one byte in the provided return mask.

Data type and casting updates:

  • Changed the data type ofcurrent_protocol fromuint8_t touint32_t to accommodate a wider range of values.
  • Updated theesp_wifi_get_protocol function calls to cast the address ofcurrent_protocol touint8_t* to match the expected parameter type.[1][2]

Fixes:#11218

@github-actionsGitHub Actions
Copy link
Contributor

github-actionsbot commentedApr 11, 2025
edited
Loading

Messages
📖🎉 Good Job! All checks are passing!

👋Hello me-no-dev, we appreciate your contribution to this project!


📘 Please review the project'sContributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you haveread and signed theContributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by thePR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with eachpush event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger isnot a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manuallyretry these Danger checks, please navigate to theActions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫dangerJS againste65dd57

@github-actionsGitHub Actions
Copy link
Contributor

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32P4💚 -1200.000.00000.000.00
ESP32S3💚 -1200.000.00000.000.00
ESP32S2💚 -1200.000.00000.000.00
ESP32C3💚 -1000.000.00000.000.00
ESP32C6💚 -1000.000.00000.000.00
ESP32000.000.00000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32P4ESP32S3ESP32S2ESP32C3ESP32C6ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
libraries/WiFi/examples/FTM/FTM_Initiator💚 -1000000💚 -100💚 -10000
libraries/WiFi/examples/FTM/FTM_Responder💚 -1000000💚 -100💚 -10000
libraries/WiFi/examples/SimpleWiFiServer💚 -1000000💚 -100💚 -10000
libraries/WiFi/examples/WiFiAccessPoint💚 -100💚 -12000💚 -100💚 -10000
libraries/WiFi/examples/WiFiClient💚 -1000000💚 -100💚 -10000
libraries/WiFi/examples/WiFiClientBasic💚 -1000000💚 -100💚 -10000
libraries/WiFi/examples/WiFiClientConnect💚 -1000000💚 -100💚 -10000
libraries/WiFi/examples/WiFiClientEvents💚 -100💚 -12000💚 -100💚 -10000
libraries/WiFi/examples/WiFiClientStaticIP💚 -1200000💚 -100💚 -10000
libraries/WiFi/examples/WiFiExtender💚 -1000000💚 -100💚 -10000
libraries/WiFi/examples/WiFiIPv6💚 -1000000💚 -100💚 -10000
libraries/WiFi/examples/WiFiMulti💚 -1000000💚 -100💚 -10000
libraries/WiFi/examples/WiFiMultiAdvanced💚 -1000000💚 -100💚 -10000
libraries/WiFi/examples/WiFiScan💚 -1000000💚 -100💚 -10000
libraries/WiFi/examples/WiFiScanAsync💚 -1000000💚 -100💚 -10000
libraries/WiFi/examples/WiFiScanDualAntenna💚 -1000000💚 -100💚 -10000
libraries/WiFi/examples/WiFiScanTime💚 -1000000💚 -100💚 -10000
libraries/WiFi/examples/WiFiTelnetToSerial💚 -1000000💚 -100💚 -10000
libraries/WiFi/examples/WiFiUDPClient💚 -10000💚 -120💚 -100💚 -10000
libraries/WiFi/examples/WPS--00💚 -120💚 -100💚 -10000
libraries/WiFi/examples/WiFiBlueToothSwitch--00--💚 -100💚 -10000
libraries/WiFi/examples/WiFiClientEnterprise--0000💚 -100💚 -10000
libraries/WiFi/examples/WiFiSmartConfig--0000💚 -100💚 -10000

@github-actionsGitHub Actions
Copy link
Contributor

github-actionsbot commentedApr 11, 2025
edited
Loading

Test Results

 76 files   76 suites   13m 29s ⏱️
 38 tests  38 ✅ 0 💤 0 ❌
241 runs  241 ✅ 0 💤 0 ❌

Results for commite65dd57.

♻️ This comment has been updated with latest results.

@P-R-O-C-H-YP-R-O-C-H-Y added the Area: WiFiIssue related to WiFi labelApr 11, 2025
@me-no-devme-no-dev added the Status: Pending MergePull Request is ready to be merged labelApr 14, 2025
@me-no-devme-no-dev merged commitf122366 intomasterApr 14, 2025
56 checks passed
@me-no-devme-no-dev deleted the me-no-dev-patch-1 branchApril 14, 2025 10:54
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@lucasssvazlucasssvazlucasssvaz approved these changes

@P-R-O-C-H-YP-R-O-C-H-YP-R-O-C-H-Y approved these changes

Assignees
No one assigned
Labels
Area: WiFiIssue related to WiFiStatus: Pending MergePull Request is ready to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Buffer overflow / stack smashing in WiFiGenericClass::mode()
3 participants
@me-no-dev@lucasssvaz@P-R-O-C-H-Y

[8]ページ先頭

©2009-2025 Movatter.jp