Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(zigbee): Add battery voltage attribute support#11210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

P-R-O-C-H-Y
Copy link
Member

Description of Change

This pull request includes updates to the Zigbee Power Config Cluster adding a battery voltage functionality. The most important changes involve adding support for setting and reporting battery voltage in addition to battery percentage.

Enhancements to battery management:

Note: Battery Voltage attribute is not reportable, that's why there is no report method for that.

Tests scenarios

Tested using Sleepy example and HomeAssistant ZHA integration (only battery % was shown, but I was able to read the voltage value).

Related links

Closes#11177

@P-R-O-C-H-YP-R-O-C-H-Y added Status: Review neededIssue or PR is awaiting review Area: ZigbeeIssues and Feature Request about Zigbee labelsApr 1, 2025
@P-R-O-C-H-YP-R-O-C-H-Y self-assigned thisApr 1, 2025
@github-actionsGitHub Actions
Copy link
Contributor

github-actionsbot commentedApr 1, 2025•
edited
Loading

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message"Update libraries/Zigbee/examples/Zigbee_Temp_Hum_Sensor_Sleepy/Zigbee_Temp_Hum_Sensor_Sleepy.ino":
    • summary looks empty
    • type/action looks empty
  • the commit message"Update libraries/Zigbee/src/ZigbeeEP.cpp":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • followConventional Commits style
  • correct format of commit message should be:<type/action>(<scope/component>): <summary>, for examplefix(esp32): Fixed startup timeout issue
  • allowed types are:change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 10 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses theConventional Precommit Linter).

👋Hello P-R-O-C-H-Y, we appreciate your contribution to this project!

📘 Please review the project'sContributions Guide for key guidelines on code, documentation, testing, and more.
🖊️ Please also make sure you haveread and signed theContributor License Agreement for this project.
Click to see more instructions ...


This automated output is generated by thePR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with eachpush event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger isnot a substitute for human code reviews; it's still important to request a code review from your colleagues.
-Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manuallyretry these Danger checks, please navigate to theActions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫dangerJS against6eed3db

@github-actionsGitHub Actions
Copy link
Contributor

github-actionsbot commentedApr 1, 2025•
edited
Loading

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32S30⚠️ +280.000.00000.000.00
ESP32S20⚠️ +280.000.00000.000.00
ESP32C3000.000.00000.000.00
ESP32C60⚠️ +240.000.00000.000.00
ESP32H20⚠️ +220.000.00000.000.00
ESP320⚠️ +280.000.00000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32S3ESP32S2ESP32C3ESP32C6ESP32H2ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
libraries/Zigbee/examples/Zigbee_Color_Dimmer_Switch⚠️ +280⚠️ +280000000⚠️ +280
libraries/Zigbee/examples/Zigbee_Gateway⚠️ +280⚠️ +28000----⚠️ +280
libraries/Zigbee/examples/Zigbee_On_Off_Switch⚠️ +280⚠️ +280000000⚠️ +280
libraries/Zigbee/examples/Zigbee_Range_Extender⚠️ +280⚠️ +280000000⚠️ +280
libraries/Zigbee/examples/Zigbee_Thermostat⚠️ +280⚠️ +280000000⚠️ +280
libraries/Zigbee/examples/Zigbee_Analog_Input_Output------0000--
libraries/Zigbee/examples/Zigbee_CarbonDioxide_Sensor------0000--
libraries/Zigbee/examples/Zigbee_Color_Dimmable_Light------0000--
libraries/Zigbee/examples/Zigbee_Contact_Switch------0000--
libraries/Zigbee/examples/Zigbee_Dimmable_Light------0000--
libraries/Zigbee/examples/Zigbee_Illuminance_Sensor------⚠️ +240⚠️ +220--
libraries/Zigbee/examples/Zigbee_OTA_Client------0000--
libraries/Zigbee/examples/Zigbee_Occupancy_Sensor------0000--
libraries/Zigbee/examples/Zigbee_On_Off_Light------0000--
libraries/Zigbee/examples/Zigbee_PM25_Sensor------0000--
libraries/Zigbee/examples/Zigbee_Pressure_Flow_Sensor------0000--
libraries/Zigbee/examples/Zigbee_Scan_Networks------0000--
libraries/Zigbee/examples/Zigbee_Temp_Hum_Sensor_Sleepy------⚠️ +180⚠️ +180--
libraries/Zigbee/examples/Zigbee_Temperature_Sensor------0000--
libraries/Zigbee/examples/Zigbee_Vibration_Sensor------0000--
libraries/Zigbee/examples/Zigbee_Wind_Speed_Sensor------0000--
libraries/Zigbee/examples/Zigbee_Window_Covering------0000--

@github-actionsGitHub Actions
Copy link
Contributor

github-actionsbot commentedApr 1, 2025•
edited
Loading

Test Results

 76 files   76 suites   12m 41s ⏱️
 38 tests  38 ✅ 0 💤 0 ❌
241 runs  241 ✅ 0 💤 0 ❌

Results for commit6eed3db.

♻️ This comment has been updated with latest results.

@me-no-devme-no-dev requested a review fromCopilotApril 3, 2025 12:14
Copy link
Contributor

@CopilotCopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR adds battery voltage attribute support to the Zigbee Power Config Cluster by updating method signatures and implementations to accept battery voltage along with battery percentage.

  • Updated ZigbeeEP.h to introduce a new parameter and method for battery voltage.
  • Modified ZigbeeEP.cpp to update the setPowerSource method and implement setBatteryVoltage with corresponding error handling.
  • Adjusted the Sleepy example to include the battery voltage parameter in the demonstration.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

FileDescription
libraries/Zigbee/src/ZigbeeEP.hAdded battery voltage parameter to setPowerSource and a new setBatteryVoltage method.
libraries/Zigbee/src/ZigbeeEP.cppAdjusted method signature for setPowerSource and implemented setBatteryVoltage; contains an incorrect error message for battery voltage.
libraries/Zigbee/examples/Zigbee_Temp_Hum_Sensor_Sleepy/Zigbee_Temp_Hum_Sensor_Sleepy.inoUpdated the example to use the new method signature with battery voltage.

P-R-O-C-H-Yand others added2 commitsApril 3, 2025 14:19
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…_Temp_Hum_Sensor_Sleepy.inoCo-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Collaborator

@SuGliderSuGlider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@P-R-O-C-H-YP-R-O-C-H-Y added Status: Pending MergePull Request is ready to be merged and removed Status: Review neededIssue or PR is awaiting review labelsApr 7, 2025
@me-no-devme-no-dev merged commitd3509ef intoespressif:masterApr 9, 2025
56 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

Copilot code reviewCopilotCopilot left review comments

@me-no-devme-no-devme-no-dev approved these changes

@SuGliderSuGliderSuGlider approved these changes

Assignees

@P-R-O-C-H-YP-R-O-C-H-Y

Labels
Area: ZigbeeIssues and Feature Request about ZigbeeStatus: Pending MergePull Request is ready to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the Battery Voltage Cluster to Battery powered Zigbee End Points
3 participants
@P-R-O-C-H-Y@me-no-dev@SuGlider
[8]ページ先頭
©2009-2025 Movatter.jp