Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(arduino_pins): fixes Lolin-C3-Pico and C3-Mini RGB LED pin + C3-Pico SPI SCK pin definition#11186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
me-no-dev merged 2 commits intomasterfromlolin-c3-pico-pin-fix
Mar 27, 2025

Conversation

@SuGlider
Copy link
Collaborator

Description of Change

Based onhttps://www.wemos.cc/en/latest/c3/c3_pico.html there were a few pin setting errors for the Lolin-C3-Pico board.
It also fixes the RGB Pin of the Lolin-C3-Mini board, as defned inhttps://www.wemos.cc/en/latest/c3/c3_mini.html

Tests scenarios

CI only

Related links

#11184

@SuGliderSuGlider self-assigned thisMar 27, 2025
@github-actions
Copy link
Contributor

github-actionsbot commentedMar 27, 2025
edited
Loading

Messages
📖🎉 Good Job! All checks are passing!

👋Hello SuGlider, we appreciate your contribution to this project!


📘 Please review the project'sContributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you haveread and signed theContributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by thePR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with eachpush event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger isnot a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manuallyretry these Danger checks, please navigate to theActions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫dangerJS against95eeb03

@SuGliderSuGlider added Type: 3rd party BoardsRelated to third-party/non-Espressif hardware boards. Status: Review neededIssue or PR is awaiting review labelsMar 27, 2025
@SuGliderSuGlider added this to the3.2.0 milestoneMar 27, 2025
@me-no-devme-no-dev added Status: Pending MergePull Request is ready to be merged and removed Status: Review neededIssue or PR is awaiting review labelsMar 27, 2025
@me-no-devme-no-dev merged commit1ca9dab intomasterMar 27, 2025
15 of 16 checks passed
@me-no-devme-no-dev deleted the lolin-c3-pico-pin-fix branchMarch 27, 2025 10:32
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@me-no-devme-no-devme-no-dev approved these changes

@P-R-O-C-H-YP-R-O-C-H-YP-R-O-C-H-Y approved these changes

@lucasssvazlucasssvazAwaiting requested review from lucasssvaz

Assignees

@SuGliderSuGlider

Labels

Status: Pending MergePull Request is ready to be mergedType: 3rd party BoardsRelated to third-party/non-Espressif hardware boards.

Projects

Milestone

3.2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@SuGlider@me-no-dev@P-R-O-C-H-Y

[8]ページ先頭

©2009-2025 Movatter.jp