Fix memory leak
Updated almost all methods to return a boolean value and print error message with code and string of the error.
factoryReset method now have an optional parameterbool restart, by default its set to TRUE, but if false is passed, the Zigbee will just erase the nvram and the reset or reboot will need to be managed in user sketch. Example of how it can be used is the Temperature Humidity Sleepy example.
Simplified theAnalogSensor Endpoint -> removed AnalogValue, as its not commonly used in any device
FixedAnalogSensor compilation warning message

Tests scenarios

Related links

Closes#11178

feat(zigbee): Add checks on setting attrs and commands

508b6fa

P-R-O-C-H-Y added this to the3.3.0 milestone

Mar 20, 2025

P-R-O-C-H-Y added this toArduino ESP32 Core Project Roadmap

Mar 20, 2025

github-project-automationbot moved this toTodo inArduino ESP32 Core Project Roadmap

Mar 20, 2025

P-R-O-C-H-Y added the Area: ZigbeeIssues and Feature Request about Zigbee label

Mar 20, 2025

P-R-O-C-H-Y self-assigned this

Mar 20, 2025

Copy link

Contributor

github-actionsbot commentedMar 20, 2025•
edited
Loading

	Warnings
⚠️	Some issues found for the commit messages in this PR: the commit message`"fix(zigbee): Fix memory leak, print esp_zb_zcl_status_t error, remove analogValue from analog EP"`: summary appears to be too long the commit message`"fix(zigbee): Hope its finished now.."`: summary should not end with a period (full stop) the commit message`"fix/zigbee): Add missing return in WindowCovering"`: summary looks empty type/action looks empty Please fix these commit messages - here are some basic tips: followConventional Commits style correct format of commit message should be:`<type/action>(<scope/component>): <summary>`, for example`fix(esp32): Fixed startup timeout issue` allowed types are:`change,ci,docs,feat,fix,refactor,remove,revert,test` sufficiently descriptive message summary should be between 10 to 72 characters and start with upper case letter avoid Jira references in commit messages (unavailable/irrelevant for our customers) `TIP:` Install pre-commit hooks and run this check when committing (uses theConventional Precommit Linter).

	Messages
📖	This PR seems to be quite large (total lines of code: 1266), you might consider splitting it into smaller PRs

👋Hello P-R-O-C-H-Y, we appreciate your contribution to this project!

📘 Please review the project'sContributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you haveread and signed theContributor License Agreement for this project.

Click to see more instructions ...

This automated output is generated by thePR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with eachpush event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger isnot a substitute for human code reviews; it's still important to request a code review from your colleagues.
-Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- Addressing info messages (📖) is strongly recommended; they're less critical but valuable.
- To manuallyretry these Danger checks, please navigate to theActions tab and re-run last Danger workflow.

Review and merge process you can expect ...

We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫dangerJS against3bebb79

Merge branch 'master' into feat/zigbee-commands-return-check

52b0e3a

P-R-O-C-H-Y added the Status: In Progress ⚠️Issue is in progress label

Mar 20, 2025

Copy link

Contributor

github-actionsbot commentedMar 20, 2025•
edited
Loading

Test Results

76 files 76 suites 13m 27s ⏱️
38 tests 38 ✅ 0 💤 0 ❌
241 runs 241 ✅ 0 💤 0 ❌

Results for commit3bebb79.

♻️ This comment has been updated with latest results.

Copy link

Contributor

github-actionsbot commentedMar 20, 2025•
edited
Loading

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

Memory	FLASH [bytes]		FLASH [%]		RAM [bytes]		RAM [%]
Target	DEC	INC	DEC	INC	DEC	INC	DEC	INC
ESP32S3	💚 -44	0	💚 -0.01	0.00	0	0	0.00	0.00
ESP32S2	💚 -52	0	💚 -0.01	0.00	0	0	0.00	0.00
ESP32C3	💚 -54	0	💚 -0.01	0.00	0	0	0.00	0.00
ESP32C6	💚 -88	⚠️ +432	💚 -0.02	⚠️ +0.08	0	0	0.00	0.00
ESP32H2	💚 -786	⚠️ +448	💚 -0.13	⚠️ +0.08	0	0	0.00	0.00
ESP32	💚 -52	0	💚 -0.01	0.00	0	0	0.00	0.00

Click to expand the detailed deltas report [usage change in BYTES]

Target	ESP32S3		ESP32S2		ESP32C3		ESP32C6		ESP32H2		ESP32
Example	FLASH	RAM	FLASH	RAM	FLASH	RAM	FLASH	RAM	FLASH	RAM	FLASH	RAM
libraries/Zigbee/examples/Zigbee_Color_Dimmer_Switch	💚 -44	0	💚 -52	0	💚 -54	0	💚 -54	0	💚 -54	0	💚 -52	0
libraries/Zigbee/examples/Zigbee_Gateway	💚 -4	0	💚 -4	0	💚 -32	0	-	-	-	-	💚 -20	0
libraries/Zigbee/examples/Zigbee_On_Off_Switch	💚 -28	0	💚 -16	0	💚 -30	0	💚 -28	0	💚 -30	0	💚 -28	0
libraries/Zigbee/examples/Zigbee_Range_Extender	💚 -20	0	0	0	💚 -42	0	💚 -42	0	💚 -38	0	💚 -20	0
libraries/Zigbee/examples/Zigbee_Thermostat	💚 -24	0	💚 -20	0	💚 -38	0	💚 -38	0	💚 -38	0	💚 -28	0
libraries/Zigbee/examples/Zigbee_Analog_Input_Output	-	-	-	-	-	-	💚 -88	0	💚 -88	0	-	-
libraries/Zigbee/examples/Zigbee_CarbonDioxide_Sensor	-	-	-	-	-	-	0	0	💚 -2	0	-	-
libraries/Zigbee/examples/Zigbee_Color_Dimmable_Light	-	-	-	-	-	-	💚 -28	0	💚 -28	0	-	-
libraries/Zigbee/examples/Zigbee_Contact_Switch	-	-	-	-	-	-	0	0	💚 -4	0	-	-
libraries/Zigbee/examples/Zigbee_Dimmable_Light	-	-	-	-	-	-	💚 -30	0	💚 -30	0	-	-
libraries/Zigbee/examples/Zigbee_Illuminance_Sensor	-	-	-	-	-	-	⚠️ +28	0	⚠️ +28	0	-	-
libraries/Zigbee/examples/Zigbee_OTA_Client	-	-	-	-	-	-	💚 -24	0	💚 -786	0	-	-
libraries/Zigbee/examples/Zigbee_Occupancy_Sensor	-	-	-	-	-	-	💚 -22	0	💚 -22	0	-	-
libraries/Zigbee/examples/Zigbee_On_Off_Light	-	-	-	-	-	-	💚 -34	0	💚 -30	0	-	-
libraries/Zigbee/examples/Zigbee_Pressure_Flow_Sensor	-	-	-	-	-	-	⚠️ +46	0	⚠️ +46	0	-	-
libraries/Zigbee/examples/Zigbee_Scan_Networks	-	-	-	-	-	-	0	0	0	0	-	-
libraries/Zigbee/examples/Zigbee_Temp_Hum_Sensor_Sleepy	-	-	-	-	-	-	⚠️ +432	0	⚠️ +448	0	-	-
libraries/Zigbee/examples/Zigbee_Temperature_Sensor	-	-	-	-	-	-	⚠️ +30	0	⚠️ +32	0	-	-
libraries/Zigbee/examples/Zigbee_Vibration_Sensor	-	-	-	-	-	-	💚 -26	0	💚 -26	0	-	-
libraries/Zigbee/examples/Zigbee_Wind_Speed_Sensor	-	-	-	-	-	-	⚠️ +2	0	⚠️ +2	0	-	-
libraries/Zigbee/examples/Zigbee_Window_Covering	-	-	-	-	-	-	⚠️ +10	0	⚠️ +10	0	-	-

Copy link

Member

me-no-dev commentedMar 20, 2025

Please format errors like this:

esp_err_t err = esp_wifi_set_max_tx_power(power);if (err != ESP_OK) {log_e("Failed to set TX Power: 0x%x: %s", err,esp_err_to_name(err));  }

feat(zigbee): Add error info in the logs

80eba94

P-R-O-C-H-Y force-pushed thefeat/zigbee-commands-return-check branch from104a381 to80eba94Compare

March 21, 2025 11:43

P-R-O-C-H-Y added Status: Review neededIssue or PR is awaiting review and removed Status: In Progress ⚠️Issue is in progress labels

Mar 24, 2025

P-R-O-C-H-Y moved this fromTodo toIn Review inArduino ESP32 Core Project Roadmap

Mar 24, 2025

P-R-O-C-H-Y marked this pull request as ready for review

March 24, 2025 13:10

SuGlider reviewed

Mar 27, 2025

View reviewed changes

libraries/Zigbee/src/ZigbeeEP.cpp OutdatedShow resolvedHide resolved

Copy link

Collaborator

SuGlider commentedMar 27, 2025•
edited
Loading

@P-R-O-C-H-Y - please review the code in ZigbeeEP.cpp ::void ZigbeeEP::zbReadBasicCluster(const esp_zb_zcl_attribute_t *attribute). It has 2malloc() with no correspondentfree(). This will certainly cause memory leak.

Better think and review the whole zigbee code whenever usingnew ormalloc.

SuGlider self-requested a review

March 27, 2025 02:55

SuGlider requested changes

Mar 27, 2025

View reviewed changes

Copy link

Collaborator

SuGlider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

From a fast code read, I understand that ZigbeeEP.cpp can cause memory leaks.
It may happen in other code files as well.

I recommend reviewing all places wherenew ormalloc is used.

me-no-dev marked this pull request as draft

March 27, 2025 10:32

Copy link

MemberAuthor

P-R-O-C-H-Y commentedMar 27, 2025

Thanks@SuGlider, will take a look.

P-R-O-C-H-Y added Status: In Progress ⚠️Issue is in progress and removed Status: Review neededIssue or PR is awaiting review labels

Mar 27, 2025

P-R-O-C-H-Y added4 commits

March 27, 2025 15:07

fix(zigbee): Fix memory leak, print esp_zb_zcl_status_t error, remove…

160e286

… analogValue from analog EP

feat(example): Update factoryResetoption in sleepy example

8e55674

Merge branch 'master' into feat/zigbee-commands-return-check

382073a

fix(zigbee): Add error checks to Illuminance EP

65b9383

P-R-O-C-H-Y marked this pull request as ready for review

March 27, 2025 14:13

P-R-O-C-H-Y changed the title~~feat(zigbee): Add checks on set attributes and commands~~feat(zigbee): Add check, boolean returns, fix Analog, add optional reset on factoryReset

Mar 27, 2025

P-R-O-C-H-Y requested review fromSuGlider,lucasssvaz andme-no-dev

March 27, 2025 14:22

P-R-O-C-H-Y added Status: Review neededIssue or PR is awaiting review and removed Status: In Progress ⚠️Issue is in progress labels

Mar 27, 2025

P-R-O-C-H-Y modified the milestones:3.3.0,3.2.0

Mar 27, 2025