- Notifications
You must be signed in to change notification settings - Fork7.8k
fix(camera_webserver): Fix typo in OV2640 definition#11145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
github-actionsbot commentedMar 19, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
👋Hello lucasssvaz, we appreciate your contribution to this project! 📘 Please review the project'sContributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you haveread and signed theContributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
me-no-dev commentedMar 19, 2025
I wonder why the difference is 100 bytes when two characters were changed/swapped |
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
| ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
lucasssvaz commentedMar 19, 2025
I also don't know but maybe it is related to the GZ compression algorithm. |
66abd86 intoespressif:masterUh oh!
There was an error while loading.Please reload this page.
beta-tester commentedMar 22, 2025
I had to refrain from fixing the error myself several times and submitting my own pull request, because I was afraid that the index.html file with the typo issue was in plain text somewhere, and the typo hadn't been fixed there. If another change is made to this index.html file, I fear that the typo error will be reintroduced. |
lucasssvaz commentedMar 22, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There isn't any other typos in |
beta-tester commentedMar 26, 2025
that means, if somebody would add things to the index.html page have to extract and un-gz the data of the camera_index.h file, make the changes and gz it again? okay, so no "master" index.html template file exists. thanks for clarification. |
Uh oh!
There was an error while loading.Please reload this page.
Description of Change
Fix typo in OV2640's index of the
CameraWebServerexample.Created by following instructions in the issue.
Related links
Closes#10906