Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(camera_webserver): Fix typo in OV2640 definition#11145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
me-no-dev merged 1 commit intoespressif:masterfromlucasssvaz:fix/camera
Mar 20, 2025

Conversation

@lucasssvaz
Copy link
Member

@lucasssvazlucasssvaz commentedMar 19, 2025
edited
Loading

Description of Change

Fix typo in OV2640's index of theCameraWebServer example.

Created by following instructions in the issue.

Related links

Closes#10906

@lucasssvazlucasssvaz added the Type: ExampleIssue is related to specific example. labelMar 19, 2025
@lucasssvazlucasssvaz self-assigned thisMar 19, 2025
@github-actions
Copy link
Contributor

github-actionsbot commentedMar 19, 2025
edited
Loading

Messages
📖🎉 Good Job! All checks are passing!

👋Hello lucasssvaz, we appreciate your contribution to this project!


📘 Please review the project'sContributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you haveread and signed theContributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by thePR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with eachpush event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger isnot a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manuallyretry these Danger checks, please navigate to theActions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫dangerJS against595aa1b

@me-no-dev
Copy link
Member

I wonder why the difference is 100 bytes when two characters were changed/swapped

SuGlider reacted with eyes emoji

@github-actions
Copy link
Contributor

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32S30‼️ +5K0.00⚠️ +0.500⚠️ +4600.00⚠️ +0.74
ESP32S20‼️ +4K0.00⚠️ +0.390⚠️ +120.00⚠️ +0.02
ESP320‼️ +12K0.00‼️ +1.200⚠️ +920.00⚠️ +0.14
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32S3ESP32S2ESP32
ExampleFLASHRAMFLASHRAMFLASHRAM
ESP32/examples/Camera/CameraWebServer‼️ +5K⚠️ +460‼️ +4K⚠️ +12‼️ +12K⚠️ +92

@lucasssvaz
Copy link
MemberAuthor

I wonder why the difference is 100 bytes when two characters were changed/swapped

I also don't know but maybe it is related to the GZ compression algorithm.

@me-no-devme-no-dev added the Status: Pending MergePull Request is ready to be merged labelMar 20, 2025
@me-no-devme-no-dev merged commit66abd86 intoespressif:masterMar 20, 2025
25 checks passed
@beta-tester
Copy link

I had to refrain from fixing the error myself several times and submitting my own pull request, because I was afraid that the index.html file with the typo issue was in plain text somewhere, and the typo hadn't been fixed there. If another change is made to this index.html file, I fear that the typo error will be reintroduced.

@lucasssvaz
Copy link
MemberAuthor

lucasssvaz commentedMar 22, 2025
edited
Loading

I had to refrain from fixing the error myself several times and submitting my own pull request, because I was afraid that the index.html file with the typo issue was in plain text somewhere, and the typo hadn't been fixed there. If another change is made to this index.html file, I fear that the typo error will be reintroduced.

There isn't any other typos inarduino-esp32,esp32-arduino-lib-builder andesp-idf (and its components). We don't use files from anywhere else.

@beta-tester
Copy link

I had to refrain from fixing the error myself several times and submitting my own pull request, because I was afraid that the index.html file with the typo issue was in plain text somewhere, and the typo hadn't been fixed there. If another change is made to this index.html file, I fear that the typo error will be reintroduced.

There isn't any other typos inarduino-esp32,esp32-arduino-lib-builder andesp-idf (and its components). We don't use files from anywhere else.

that means, if somebody would add things to the index.html page have to extract and un-gz the data of the camera_index.h file, make the changes and gz it again?

okay, so no "master" index.html template file exists. thanks for clarification.

lucasssvaz reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

@lucasssvazlucasssvaz

Labels

Status: Pending MergePull Request is ready to be mergedType: ExampleIssue is related to specific example.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

there is still a typo in camera_index.h OV2460 -> OV2640

3 participants

@lucasssvaz@me-no-dev@beta-tester

[8]ページ先頭

©2009-2025 Movatter.jp