Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(eth): Add setters for negotiation, speed and duplex modes#11053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
me-no-dev merged 2 commits intomasterfromfeat/eth_opts
Mar 10, 2025

Conversation

@me-no-dev
Copy link
Member

This pull request introduces several new methods and modifications to theETHClass in the Ethernet library to enhance its functionality. The primary changes include adding methods to set duplex mode, auto-negotiation, and link speed, as well as updating the return type of thelinkSpeed method.

Enhancements toETHClass:

  • AddedsetFullDuplex method to allow setting the duplex mode of the Ethernet connection.
  • AddedsetAutoNegotiation method to enable or disable auto-negotiation on the Ethernet connection.
  • AddedsetLinkSpeed method to set the link speed of the Ethernet connection.
  • UpdatedlinkSpeed method to returnuint16_t instead ofuint8_t for better compatibility with link speed values.

Header file updates:

  • UpdatedETH.h to declare the new methods and modify the return type oflinkSpeed.

fixes:#10923

SuGlider reacted with thumbs up emoji
@github-actions
Copy link
Contributor

github-actionsbot commentedMar 7, 2025•
edited
Loading

Messages
📖🎉 Good Job! All checks are passing!

👋Hello me-no-dev, we appreciate your contribution to this project!

📘 Please review the project'sContributions Guide for key guidelines on code, documentation, testing, and more.
🖊️ Please also make sure you haveread and signed theContributor License Agreement for this project.
Click to see more instructions ...


This automated output is generated by thePR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with eachpush event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger isnot a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manuallyretry these Danger checks, please navigate to theActions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫dangerJS against922ef56

@me-no-devme-no-dev added the Status: Review neededIssue or PR is awaiting review labelMar 7, 2025
@github-actions
Copy link
Contributor

github-actionsbot commentedMar 7, 2025•
edited
Loading

Test Results

 76 files   76 suites   13m 19s ⏱️
 38 tests  38 ✅ 0 💤 0 ❌
241 runs  241 ✅ 0 💤 0 ❌

Results for commit922ef56.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32P4000.000.00000.000.00
ESP32S30⚠️ +840.00⚠️ +0.01000.000.00
ESP32S20⚠️ +840.00⚠️ +0.02000.000.00
ESP32C3000.000.00000.000.00
ESP32C6000.000.00000.000.00
ESP32H2000.000.00000.000.00
ESP320⚠️ +840.00⚠️ +0.02000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32P4ESP32S3ESP32S2ESP32C3ESP32C6ESP32H2ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
Ethernet/examples/ETH_TLK11000----------⚠️ +840
Ethernet/examples/ETH_W5500_Arduino_SPI00⚠️ +840⚠️ +840000000⚠️ +840
Ethernet/examples/ETH_W5500_IDF_SPI00⚠️ +840⚠️ +840000000⚠️ +840
Ethernet/examples/ETH_WIFI_BRIDGE00⚠️ +840⚠️ +8400000--⚠️ +840
Ethernet/examples/ETH_LAN8720------------⚠️ +840

Copy link
Member

@P-R-O-C-H-YP-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Overall LGTM

Copy link
Collaborator

@SuGliderSuGlider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@SuGliderSuGlider added Status: Pending MergePull Request is ready to be merged and removed Status: Review neededIssue or PR is awaiting review labelsMar 10, 2025
@SuGliderSuGlider added this to the3.2.0 milestoneMar 10, 2025
@me-no-devme-no-dev merged commitbf5265c intomasterMar 10, 2025
46 checks passed
@me-no-devme-no-dev deleted the feat/eth_opts branchMarch 10, 2025 19:20
@WebDust21
Copy link
Contributor

Note that as pointed out in the initial post in#10923, these added functions are effectively unusable. The ioctl call stipulations require the driver to be created, yet not started--which is not a possible state from Arduino-ESP32 Eth, as "eth.begin" both creates and starts the driver before returning.

ETH_CMD_S_SPEED ->https://github.com/espressif/esp-idf/blob/1f46216a7214e27c1e351b4310acf7fcd77029d4/components/esp_eth/src/esp_eth.c#L474
ETH_CMD_S_AUTONEGO ->https://github.com/espressif/esp-idf/blob/1f46216a7214e27c1e351b4310acf7fcd77029d4/components/esp_eth/src/esp_eth.c#L460
ETH_CMD_S_DUPLEX_MODE ->https://github.com/espressif/esp-idf/blob/1f46216a7214e27c1e351b4310acf7fcd77029d4/components/esp_eth/src/esp_eth.c#L495

About the only way these can effectively be implemented with the current ecosystem, is if they are added as arguments to "eth.begin()". That way, if the user wanted to change the rate, they could stop it with "eth.end()", then restart with different args to "eth.begin()".

@me-no-dev
Copy link
MemberAuthor

@WebDust21 will be possible to do with the same API. I'll rework how things are done. Basically you will call the methods beforebegin() and inbegin() they will get executed with the selected settings

WebDust21 reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@P-R-O-C-H-YP-R-O-C-H-YP-R-O-C-H-Y approved these changes

@SuGliderSuGliderSuGlider approved these changes

Assignees

No one assigned

Labels

Status: Pending MergePull Request is ready to be merged

Projects

Milestone

3.2.0

Development

Successfully merging this pull request may close these issues.

Support setting the Link Speed for Ethernet

4 participants

@me-no-dev@WebDust21@SuGlider@P-R-O-C-H-Y
[8]ページ先頭
©2009-2025 Movatter.jp