Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(eth): Fix RMII Ethernet not being able to be restarted#11048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
me-no-dev merged 1 commit intomasterfrombugfix/rmii_eth_end_begin
Mar 10, 2025

Conversation

@me-no-dev
Copy link
Member

This pull request includes changes to theETHClass::begin method in thelibraries/Ethernet/src/ETH.cpp file. The main purpose of these changes is to improve the initialization process of the Ethernet MAC and PHY by storing the created instances in class member variables instead of local variables.

Initialization improvements:

  • Changed themac variable to a class member variable_mac and updated the error handling to use_mac.
  • Changed thephy variable to a class member variable_phy and updated the error handling to use_phy.
  • Updated the switch cases for different PHY types to assign the new PHY instances to_phy instead ofphy.
  • Modified theeth_config initialization to use the class member variables_mac and_phy instead of the local variablesmac andphy.

@github-actions
Copy link
Contributor

Messages
📖🎉 Good Job! All checks are passing!

👋Hello me-no-dev, we appreciate your contribution to this project!


📘 Please review the project'sContributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you haveread and signed theContributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by thePR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with eachpush event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger isnot a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manuallyretry these Danger checks, please navigate to theActions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫dangerJS against5a710be

@me-no-devme-no-dev added the Status: Review neededIssue or PR is awaiting review labelMar 7, 2025
@github-actions
Copy link
Contributor

github-actionsbot commentedMar 7, 2025
edited
Loading

Test Results

 76 files   76 suites   12m 43s ⏱️
 38 tests  38 ✅ 0 💤 0 ❌
241 runs  241 ✅ 0 💤 0 ❌

Results for commit5a710be.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32P40⚠️ +40.000.00000.000.00
ESP32S3000.000.00000.000.00
ESP32S2000.000.00000.000.00
ESP32C3000.000.00000.000.00
ESP32C6000.000.00000.000.00
ESP32H2000.000.00000.000.00
ESP32💚 -400.000.00000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32P4ESP32S3ESP32S2ESP32C3ESP32C6ESP32H2ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
Ethernet/examples/ETH_TLK110⚠️ +40----------💚 -40
Ethernet/examples/ETH_W5500_Arduino_SPI00000000000000
Ethernet/examples/ETH_W5500_IDF_SPI00000000000000
Ethernet/examples/ETH_WIFI_BRIDGE0000000000--00
Ethernet/examples/ETH_LAN8720------------💚 -40

Copy link
Collaborator

@SuGliderSuGlider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@SuGliderSuGlider added Status: Pending MergePull Request is ready to be merged and removed Status: Review neededIssue or PR is awaiting review labelsMar 10, 2025
@SuGliderSuGlider added this to the3.2.0 milestoneMar 10, 2025
@me-no-devme-no-dev merged commit8575d04 intomasterMar 10, 2025
67 of 76 checks passed
@me-no-devme-no-dev deleted the bugfix/rmii_eth_end_begin branchMarch 10, 2025 19:19
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@SuGliderSuGliderSuGlider approved these changes

@P-R-O-C-H-YP-R-O-C-H-YP-R-O-C-H-Y approved these changes

+1 more reviewer

@TD-erTD-erTD-er left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Status: Pending MergePull Request is ready to be merged

Projects

Milestone

3.2.0

Development

Successfully merging this pull request may close these issues.

5 participants

@me-no-dev@TD-er@SuGlider@P-R-O-C-H-Y

[8]ページ先頭

©2009-2025 Movatter.jp