Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(zigbee): use correct pressure cluster function in setTolerance#11008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
me-no-dev merged 2 commits intoespressif:masterfromoddlama:master
Feb 25, 2025

Conversation

@oddlama
Copy link
Contributor

@oddlamaoddlama commentedFeb 25, 2025
edited
Loading

By completing this PR sufficiently, you help us to review this Pull Request quicker and also help improve the quality of Release Notes

Checklist

  1. Please provide specific title of the PR describing the change, including the component name (eg. „Update of Documentation link on Readme.md“)
  2. Please provide related links (eg. Issue which will be closed by this Pull Request)
  3. Pleaseupdate relevant Documentation if applicable
  4. Please checkContributing guide
  5. Pleaseconfirm option to "Allow edits and access to secrets by maintainers" when opening a Pull Request

This entire section above can be deleted if all items are checked.


Description of Change

Fixed calling a temperature cluster function on a pressure cluster insetTolerance.

Tests scenarios

ESP32-C6

Related links

N/A

@CLAassistant
Copy link

CLAassistant commentedFeb 25, 2025
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link
Contributor

github-actionsbot commentedFeb 25, 2025
edited
Loading

Messages
📖🎉 Good Job! All checks are passing!

👋Hello oddlama, we appreciate your contribution to this project!


📘 Please review the project'sContributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you haveread and signed theContributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by thePR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with eachpush event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger isnot a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manuallyretry these Danger checks, please navigate to theActions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫dangerJS against264d111

Copy link
Member

@P-R-O-C-H-YP-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice catch :) Thanks@oddlama for the fix

@P-R-O-C-H-YP-R-O-C-H-Y added Area: ZigbeeIssues and Feature Request about Zigbee Status: Pending MergePull Request is ready to be merged labelsFeb 25, 2025
@github-actions
Copy link
Contributor

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32C6💚 -960💚 -0.020.00000.000.00
ESP32H2💚 -960💚 -0.020.00000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32C6ESP32H2
ExampleFLASHRAMFLASHRAM
Zigbee/examples/Zigbee_Analog_Input_Output0000
Zigbee/examples/Zigbee_CarbonDioxide_Sensor0000
Zigbee/examples/Zigbee_Color_Dimmable_Light0000
Zigbee/examples/Zigbee_Color_Dimmer_Switch0000
Zigbee/examples/Zigbee_Contact_Switch0000
Zigbee/examples/Zigbee_Dimmable_Light0000
Zigbee/examples/Zigbee_OTA_Client0000
Zigbee/examples/Zigbee_Occupancy_Sensor0000
Zigbee/examples/Zigbee_On_Off_Light0000
Zigbee/examples/Zigbee_On_Off_Switch0000
Zigbee/examples/Zigbee_Pressure_Flow_Sensor💚 -960💚 -960
Zigbee/examples/Zigbee_Range_Extender0000
Zigbee/examples/Zigbee_Scan_Networks0000
Zigbee/examples/Zigbee_Temp_Hum_Sensor_Sleepy0000
Zigbee/examples/Zigbee_Temperature_Sensor0000
Zigbee/examples/Zigbee_Thermostat0000
Zigbee/examples/Zigbee_Vibration_Sensor0000
Zigbee/examples/Zigbee_Window_Covering0000

@me-no-devme-no-dev merged commit1467d87 intoespressif:masterFeb 25, 2025
47 of 54 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@P-R-O-C-H-YP-R-O-C-H-YP-R-O-C-H-Y approved these changes

Assignees

No one assigned

Labels

Area: ZigbeeIssues and Feature Request about ZigbeeStatus: Pending MergePull Request is ready to be merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@oddlama@CLAassistant@P-R-O-C-H-Y@me-no-dev

[8]ページ先頭

©2009-2025 Movatter.jp