Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(board): Update feathers3 wire1 pin definition#11001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
me-no-dev merged 3 commits intoespressif:masterfromericlewis:patch-1
Feb 25, 2025

Conversation

@ericlewis
Copy link
Contributor

By completing this PR sufficiently, you help us to review this Pull Request quicker and also help improve the quality of Release Notes

Checklist

  1. Please provide specific title of the PR describing the change, including the component name (eg. „Update of Documentation link on Readme.md“)
  2. Please provide related links (eg. Issue which will be closed by this Pull Request)
  3. Pleaseupdate relevant Documentation if applicable
  4. Please checkContributing guide
  5. Pleaseconfirm option to "Allow edits and access to secrets by maintainers" when opening a Pull Request

This entire section above can be deleted if all items are checked.

Description of Change

Please describe your proposed Pull Request and it's impact.
add wire1 definition

Tests scenarios

Please describe on what Hardware and Software combinations you have tested this Pull Request and how.
feathers3 rev 8 from unexpected maker

Related links

Please provide links to related issue, PRs etc.

(eg. Closes #number of issue)

@CLAassistant
Copy link

CLAassistant commentedFeb 21, 2025•
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link
Contributor

github-actionsbot commentedFeb 21, 2025•
edited
Loading

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message"update feathers3 wire1 pin definition":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • followConventional Commits style
  • correct format of commit message should be:<type/action>(<scope/component>): <summary>, for examplefix(esp32): Fixed startup timeout issue
  • allowed types are:change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 10 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses theConventional Precommit Linter).

👋Hello ericlewis, we appreciate your contribution to this project!

📘 Please review the project'sContributions Guide for key guidelines on code, documentation, testing, and more.
🖊️ Please also make sure you haveread and signed theContributor License Agreement for this project.
Click to see more instructions ...


This automated output is generated by thePR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with eachpush event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger isnot a substitute for human code reviews; it's still important to request a code review from your colleagues.
-Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manuallyretry these Danger checks, please navigate to theActions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫dangerJS against5779ef1

@P-R-O-C-H-YP-R-O-C-H-Y added the Type: 3rd party BoardsRelated to third-party/non-Espressif hardware boards. labelFeb 21, 2025
@P-R-O-C-H-YP-R-O-C-H-Y changed the titleupdate feathers3 wire1 pin definitionfix(boards): Update feathers3 wire1 pin definitionFeb 21, 2025
@P-R-O-C-H-YP-R-O-C-H-Y changed the titlefix(boards): Update feathers3 wire1 pin definitionfix(board): Update feathers3 wire1 pin definitionFeb 21, 2025
@P-R-O-C-H-YP-R-O-C-H-Y added the Status: Pending MergePull Request is ready to be merged labelFeb 21, 2025
@me-no-devme-no-dev added Status: Pending CLA ⚠️Contributor is required to sign the CLA and removed Status: Pending MergePull Request is ready to be merged labelsFeb 21, 2025
@me-no-dev
Copy link
Member

@ericlewis please sign CLA :)

@me-no-dev
Copy link
Member

@UnexpectedMaker PTAL

@ericlewis
Copy link
ContributorAuthor

@me-no-dev signed!

@SuGliderSuGlider removed the Status: Pending CLA ⚠️Contributor is required to sign the CLA labelFeb 23, 2025
@SuGlider
Copy link
Collaborator

Based onhttps://esp32s3.com/feathers3.html#pins - it seems fine.

image

@SuGliderSuGlider self-requested a reviewFebruary 23, 2025 17:06
Copy link
Collaborator

@SuGliderSuGlider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@SuGliderSuGlider added the Status: Pending MergePull Request is ready to be merged labelFeb 23, 2025
@me-no-devme-no-dev merged commit164fcc6 intoespressif:masterFeb 25, 2025
11 checks passed
@ericlewisericlewis deleted the patch-1 branchMay 13, 2025 18:42
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@SuGliderSuGliderSuGlider approved these changes

@P-R-O-C-H-YP-R-O-C-H-YP-R-O-C-H-Y approved these changes

Assignees

No one assigned

Labels

Status: Pending MergePull Request is ready to be mergedType: 3rd party BoardsRelated to third-party/non-Espressif hardware boards.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ericlewis@CLAassistant@me-no-dev@SuGlider@P-R-O-C-H-Y
[8]ページ先頭
©2009-2025 Movatter.jp