Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Update of Boards.txt & variants - Adding CYObot board - 3rd party board#10947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
me-no-dev merged 10 commits intoespressif:masterfrommhpham23:master
Feb 25, 2025

Conversation

@mhpham23
Copy link
Contributor

  1. Adding Pin Header file for CYObot to variants folder
  2. Add CYObot config to boards.txt

I have tested my PR with CYObot v2 board with Arduino-ESP32 core v3.1.1

By completing this PR sufficiently, you help us to review this Pull Request quicker and also help improve the quality of Release Notes

Checklist

  1. [ x ] Please provide specific title of the PR describing the change, including the component name (eg. „Update of Documentation link on Readme.md“)
  2. [x ] Please provide related links (eg. Issue which will be closed by this Pull Request)
  3. [ x] Pleaseupdate relevant Documentation if applicable
  4. [x ] Please checkContributing guide
  5. [x ] Pleaseconfirm option to "Allow edits and access to secrets by maintainers" when opening a Pull Request

This entire section above can be deleted if all items are checked.

Description of Change

Please describe your proposed Pull Request and it's impact.

No impact

Tests scenarios

Please describe on what Hardware and Software combinations you have tested this Pull Request and how.

(eg. I have tested my Pull Request on Arduino-esp32 core v2.0.2 with ESP32 and ESP32-S2 Board with this scenario)

Related links

Please provide links to related issue, PRs etc.

(eg. Closes #number of issue)

1. Adding Pin Header file for CYObot to variants folder2. Add CYObot config to boards.txt
@CLAassistant
Copy link

CLAassistant commentedFeb 6, 2025•
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link
Contributor

github-actionsbot commentedFeb 6, 2025•
edited
Loading

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message"Adding CYObot board - 3rd party board":
    • summary looks empty
    • type/action looks empty
  • the commit message"fix(CYOBot): fix boards.txt & pin_arduino.h":
    • scope/component should be lowercase without whitespace, allowed special characters are_/.,*-.

Please fix these commit messages - here are some basic tips:

  • followConventional Commits style
  • correct format of commit message should be:<type/action>(<scope/component>): <summary>, for examplefix(esp32): Fixed startup timeout issue
  • allowed types are:change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 10 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses theConventional Precommit Linter).

👋Hello mhpham23, we appreciate your contribution to this project!

📘 Please review the project'sContributions Guide for key guidelines on code, documentation, testing, and more.
🖊️ Please also make sure you haveread and signed theContributor License Agreement for this project.
Click to see more instructions ...


This automated output is generated by thePR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with eachpush event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger isnot a substitute for human code reviews; it's still important to request a code review from your colleagues.
-Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manuallyretry these Danger checks, please navigate to theActions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫dangerJS against7ac185b

Change comments in pin header file for cyobot board
@P-R-O-C-H-Y
Copy link
Member

Hi@mhpham23,
please as this is a new board from this manufacturer, move it to the end of the boards.txt file. Thanks

@P-R-O-C-H-YP-R-O-C-H-Y added Type: 3rd party BoardsRelated to third-party/non-Espressif hardware boards. Status: Awaiting ResponseAwaiting a response from the author labelsFeb 10, 2025
Copy link
Member

@P-R-O-C-H-YP-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@P-R-O-C-H-YP-R-O-C-H-Y added Status: Pending MergePull Request is ready to be merged and removed Status: Awaiting ResponseAwaiting a response from the author labelsFeb 25, 2025
@me-no-devme-no-dev merged commitc76c2ea intoespressif:masterFeb 25, 2025
9 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@P-R-O-C-H-YP-R-O-C-H-YP-R-O-C-H-Y approved these changes

Assignees

No one assigned

Labels

Status: Pending MergePull Request is ready to be mergedType: 3rd party BoardsRelated to third-party/non-Espressif hardware boards.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mhpham23@CLAassistant@P-R-O-C-H-Y@me-no-dev
[8]ページ先頭
©2009-2025 Movatter.jp