Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(Zigbee): Support for sleepy device + Power Source and battery level + Humidity sensor cluster#10551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@P-R-O-C-H-Y
Copy link
Member

@P-R-O-C-H-YP-R-O-C-H-Y commentedNov 1, 2024•
edited
Loading

Description of Change

This PR includes:

  • Support for sleepy device (only deep-sleep is currently possible).
  • Support for selecting power source for the device. If battery is selected, the remaining percentage can be updated.
  • Support for Humidity cluster, which was added as optional for the Temperature sensor as there is no HA Device type for humidity sensor.
  • New exampleZigbee_Temp_Hum_Sensor_Sleepy, which demonstrates all the new functionalities
  • Mirror fixes and improvements

Tests scenarios

Tested with the exampleZigbee_Temp_Hum_Sensor_Sleepy on both C6/H2 which connects to the Zigbee network.
Coordinator used - SONOFF ZBDongle-E which is configured in the Home Assistant which runs on VM.

Related links

Closes#10405
Closes#10430

lboue, felipejfc, and MatthieuBalmont reacted with heart emoji
@P-R-O-C-H-YP-R-O-C-H-Y added the Area: LibrariesIssue is related to Library support. labelNov 1, 2024
@P-R-O-C-H-YP-R-O-C-H-Y self-assigned thisNov 1, 2024
@github-actions
Copy link
Contributor

github-actionsbot commentedNov 1, 2024•
edited
Loading

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message"feat(zigbee) Add humidity optional cluster + fixes":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • followConventional Commits style
  • correct format of commit message should be:<type/action>(<scope/component>): <summary>, for examplefix(esp32): Fixed startup timeout issue
  • allowed types are:change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses theConventional Precommit Linter).

⚠️Please consider squashing your 10 commits (simplifying branch history).

👋Hello P-R-O-C-H-Y, we appreciate your contribution to this project!

Click to see more instructions ...


This automated output is generated by thePR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with eachpush event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger isnot a substitute for human code reviews; it's still important to request a code review from your colleagues.
-Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manuallyretry these Danger checks, please navigate to theActions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫dangerJS against5cb991f

@P-R-O-C-H-YP-R-O-C-H-Y mentioned this pull requestNov 1, 2024
17 tasks
@github-actions
Copy link
Contributor

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32C60⚠️ +740.00⚠️ +0.020⚠️ +160.00⚠️ +0.05
ESP32H20⚠️ +740.00⚠️ +0.010⚠️ +160.00⚠️ +0.05
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32C6ESP32H2
ExampleFLASHRAMFLASHRAM
Zigbee/examples/Zigbee_Color_Dimmable_Light⚠️ +66⚠️ +16⚠️ +68⚠️ +16
Zigbee/examples/Zigbee_Color_Dimmer_Switch⚠️ +680⚠️ +680
Zigbee/examples/Zigbee_On_Off_Light⚠️ +720⚠️ +720
Zigbee/examples/Zigbee_On_Off_Switch⚠️ +66⚠️ +16⚠️ +640
Zigbee/examples/Zigbee_Scan_Networks⚠️ +740⚠️ +740
Zigbee/examples/Zigbee_Temp_Hum_Sensor_Sleepy----
Zigbee/examples/Zigbee_Temperature_Sensor⚠️ +72⚠️ +16⚠️ +720
Zigbee/examples/Zigbee_Thermostat⚠️ +64⚠️ +16⚠️ +640

@github-actions
Copy link
Contributor

github-actionsbot commentedNov 1, 2024•
edited
Loading

Test Results

 56 files   56 suites   4m 18s ⏱️
 21 tests  21 ✅ 0 💤 0 ❌
134 runs  134 ✅ 0 💤 0 ❌

Results for commit5cb991f.

♻️ This comment has been updated with latest results.

@P-R-O-C-H-YP-R-O-C-H-Y added the Status: Review neededIssue or PR is awaiting review labelNov 1, 2024
@me-no-dev
Copy link
Member

Please create aZigbee.h header that includes all other headers and would be the only required header to include

P-R-O-C-H-Y and Daellhin reacted with thumbs up emoji

Copy link
Collaborator

@SuGliderSuGlider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. Just a few suggestion.

Copy link
Member

@lucasssvazlucasssvaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@SuGliderSuGlider self-requested a reviewNovember 6, 2024 00:04
@P-R-O-C-H-YP-R-O-C-H-Y added Status: Pending MergePull Request is ready to be merged and removed Status: Review neededIssue or PR is awaiting review labelsNov 6, 2024
@me-no-devme-no-dev merged commitd1df696 intoespressif:masterNov 6, 2024
45 of 47 checks passed
@P-R-O-C-H-YP-R-O-C-H-Y mentioned this pull requestNov 14, 2024
1 task
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@me-no-devme-no-devme-no-dev left review comments

@lucasssvazlucasssvazlucasssvaz approved these changes

@SuGliderSuGliderSuGlider approved these changes

Assignees

@P-R-O-C-H-YP-R-O-C-H-Y

Labels

Area: LibrariesIssue is related to Library support.Status: Pending MergePull Request is ready to be merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Zigbee Implementation: Battery Management, Charger Management, and Power Management Zigbee Implementation: Deep Sleep example

4 participants

@P-R-O-C-H-Y@me-no-dev@lucasssvaz@SuGlider
[8]ページ先頭
©2009-2025 Movatter.jp