Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add Info for pioarduino community version#10045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
Jason2866 wants to merge9 commits intoespressif:master
base:master
Choose a base branch
Loading
fromJason2866:patch-3

Conversation

@Jason2866
Copy link
Collaborator

@Jason2866Jason2866 commentedJul 18, 2024
edited
Loading

Add the info in documentation of the Community versionpioarduino and remove the non anymore working info about using the git Arduino master branch with Platformio.

@me-no-dev or the responsible maintainer for the docu

@github-actions
Copy link
Contributor

github-actionsbot commentedJul 18, 2024
edited
Loading

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message"'For' instead of 'To'":
    • summary looks empty
    • type/action looks empty
  • the commit message"Add Info for pioarduino community version":
    • summary looks empty
    • type/action looks empty
  • the commit message"Update to core 3.0.4":
    • summary looks empty
    • type/action looks empty
  • the commit message"Update to core 3.0.5":
    • summary looks empty
    • type/action looks empty
  • the commit message"add example Note":
    • summary looks empty
    • type/action looks empty
  • the commit message"move Platformio Info section":
    • summary looks empty
    • type/action looks empty
  • the commit message"pin Pio version and correct github source for Arduino 3.0.x":
    • summary looks empty
    • type/action looks empty
  • the commit message"remove Platformio from community sentence":
    • summary looks empty
    • type/action looks empty
  • the commit message"try to fix styling issues":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • followConventional Commits style
  • correct format of commit message should be:<type/action>(<scope/component>): <summary>, for examplefix(esp32): Fixed startup timeout issue
  • allowed types are:change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses theConventional Precommit Linter).

⚠️Please consider squashing your 9 commits (simplifying branch history).

👋Hello Jason2866, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by thePR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with eachpush event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger isnot a substitute for human code reviews; it's still important to request a code review from your colleagues.
-Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manuallyretry these Danger checks, please navigate to theActions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫dangerJS againste4f645c

@VojtechBartoskaVojtechBartoska added Type: DocumentationIssue pertains to Documentation of Arduino ESP32 IDE: PlaformIOIssue relates to PlatformIO IDE labelsJul 18, 2024
@me-no-dev
Copy link
Member

@Jason2866
Copy link
CollaboratorAuthor

GH actions seems to hung. CLA is signed.

@me-no-dev
Copy link
Member

CLA is PITA sometimes. The Pre-commit check is waiting for "Pending Merge" label (we add it once we have agreed it's good to merge)

@me-no-devme-no-dev added the Status: Review neededIssue or PR is awaiting review labelJul 21, 2024
Copy link
Member

@pedrominatelpedrominatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I have just a minor change, otherwise, LGTM.

@Linjieqiang
Copy link

How?

@lucasssvazlucasssvaz added the Status: Blocked upstream 🛑PR is waiting on upstream changes to be merged first labelDec 16, 2024
@Jason2866Jason2866 marked this pull request as draftDecember 16, 2024 18:30
@Jason2866
Copy link
CollaboratorAuthor

Needs a complete rewrite. Left open as a reminder

@lucasssvazlucasssvaz removed Status: Review neededIssue or PR is awaiting review Status: Blocked upstream 🛑PR is waiting on upstream changes to be merged first labelsJan 8, 2025
@lucasssvazlucasssvaz added the Status: In Progress ⚠️Issue is in progress labelJan 8, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@pedrominatelpedrominatelpedrominatel approved these changes

@lucasssvazlucasssvazlucasssvaz approved these changes

@P-R-O-C-H-YP-R-O-C-H-YAwaiting requested review from P-R-O-C-H-Y

Assignees

No one assigned

Labels

IDE: PlaformIOIssue relates to PlatformIO IDEStatus: In Progress ⚠️Issue is in progressType: DocumentationIssue pertains to Documentation of Arduino ESP32

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Jason2866@me-no-dev@Linjieqiang@pedrominatel@lucasssvaz@VojtechBartoska

[8]ページ先頭

©2009-2025 Movatter.jp