Commit893dba5

committed

fix(network): Fix getting fallback DNS server

- Fix getting fallback DNS server using NetworkInterface::dnsIP() getter- Remove magic number from NetworkInterface::dnsIP() setter

1 parent333bfff commit893dba5Copy full SHA for 893dba5

File tree

-3

lines changed

-3

lines changed

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -352,7 +352,7 @@ bool NetworkInterface::enableIPv6(bool en) {`
`352`	`352`	`}`
`353`	`353`
`354`	`354`	`boolNetworkInterface::dnsIP(uint8_t dns_no, IPAddress ip) {`
`355`		`-if (_esp_netif ==NULL \|\| dns_no >2) {`
	`355`	`+if (_esp_netif ==NULL \|\| dns_no >= ESP_NETIF_DNS_MAX) {`
`356`	`356`	`returnfalse;`
`357`	`357`	`}`
`358`	`358`	`esp_netif_flags_t flags =esp_netif_get_flags(_esp_netif);`
`@@ -708,11 +708,11 @@ IPAddress NetworkInterface::gatewayIP() const {`
`708`	`708`	`}`
`709`	`709`
`710`	`710`	`IPAddressNetworkInterface::dnsIP(uint8_t dns_no)const {`
`711`		`-if (_esp_netif ==NULL) {`
	`711`	`+if (_esp_netif ==NULL \|\| dns_no >= ESP_NETIF_DNS_MAX) {`
`712`	`712`	`returnIPAddress();`
`713`	`713`	`}`
`714`	`714`	`esp_netif_dns_info_t d;`
`715`		`-if (esp_netif_get_dns_info(_esp_netif, dns_no ? ESP_NETIF_DNS_BACKUP : ESP_NETIF_DNS_MAIN, &d) != ESP_OK) {`
	`715`	`+if (esp_netif_get_dns_info(_esp_netif,(esp_netif_dns_type_t)dns_no, &d) != ESP_OK) {`
`716`	`716`	`returnIPAddress();`
`717`	`717`	`}`
`718`	`718`	`if (d.ip.type == ESP_IPADDR_TYPE_V6) {`

Comments

(0)