Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

add Stream::readStringUntil function that uses string terminator#9011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
d-a-v merged 3 commits intoesp8266:masterfromArian8j2:master
Nov 7, 2023

Conversation

@Arian8j2
Copy link
Contributor

currently there is a

StringreadStringUntil(char terminator)

function, but there is no equivalent of it that uses string terminator. this pr implements

StringreadStringUntil(constchar* terminator,uint32_t count =1)

i found this useful for small html parsing or truncating.

@d-a-v
Copy link
Collaborator

It is not a breaking change and does not override the Arduino API, so looks good.
However thecount name is not intuitive.
Is it a int until_total_number_of_occurrences = 1 ?

@Arian8j2
Copy link
ContributorAuthor

Is it a int until_total_number_of_occurrences = 1 ?

yes

@d-a-v
Copy link
Collaborator

Can you please add a comment or rename the variable ?

@Arian8j2
Copy link
ContributorAuthor

Can you please add a comment or rename the variable ?

done

d-a-v reacted with thumbs up emoji

Copy link
Collaborator

@d-a-vd-a-v left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Approving: Next step is to simplifyour calls toreadStringUntil() from our libraries (especially but not onlyparsing-impl.h)

edit (or improveStream::sendUntil() with this same new API) - see#9005)

@d-a-vd-a-v merged commit31c1592 intoesp8266:masterNov 7, 2023
hasenradball pushed a commit to hasenradball/Arduino that referenced this pull requestNov 18, 2024
…8266#9011)* add readStringUntil function with string terminator* rename count parameter to untilTotalNumberOfOccurrences
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@d-a-vd-a-vd-a-v approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Arian8j2@d-a-v
[8]ページ先頭
©2009-2025 Movatter.jp