- Notifications
You must be signed in to change notification settings - Fork13.3k
umm_poison false positive from ISR#8914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
The umm_poison logic runs outside the UMM_CRITICAL_* umbrella. When interruptroutines do alloc calls, it is possible to interrupt an in-progress allocationjust before the poison is set, with a new alloc request resulting in a false"poison check fail" against the in-progress allocation. The SDK does mallocsfrom ISRs. SmartConfig can illustrate this issue.
Collaborator
mcspr commentedApr 22, 2023
Any reason not to move currently separate |
ContributorAuthor
mhightower83 commentedApr 22, 2023
The current upstream umm_malloc has umm_poison as an outer wrapper. Without searching through all the old stuff, it used to be more mixed together. I have already started to blur that separation with |
Corrected missed edit in build path for UMM_REALLOC_MINIMIZE_COPY.
mhightower83 added a commit to mhightower83/Arduino that referenced this pull requestJul 8, 2023
Bug introduced with PRfixesp8266#8914.When a reallocated pointer could not grow in place, a replacementallocation was created. Then UMM_POISON was written to the wrong block.
mhightower83 added a commit to mhightower83/Arduino that referenced this pull requestJul 9, 2023
Bug introduced with PRfixesp8266#8914
d-a-v pushed a commit that referenced this pull requestJul 18, 2023
* Fixes occasional UMM_POISON failureBug introduced with PRfix#8914.When a reallocated pointer could not grow in place, a replacementallocation was created. Then UMM_POISON was written to the wrong block.* Fix umm_poison data corruption on realloc when memory move is used.Bug introduced with PRfix#8914* refactored to resolve unused error in some build contexts
hasenradball pushed a commit to hasenradball/Arduino that referenced this pull requestNov 18, 2024
The umm_poison logic runs outside the UMM_CRITICAL_* umbrella. When interrupt routines do alloc calls, it is possible to interrupt an in-progress allocation just before the poison is set, with a new alloc request resulting in a false "poison check fail" against the in-progress allocation. The SDK does mallocs from ISRs.SmartConfig can illustrate this issue, seeesp8266#3494 (comment)Other Sketches built with Debug: "Serial," that use the SDK's Promiscuous callbacks are also likely to encounter problems.The SDK support for "Promiscuous Receive" allocates memory from an ISR context, occasionally interrupting the poison wrapper code before it finishes setting the poison fences resulting in a false poison failed event.
hasenradball pushed a commit to hasenradball/Arduino that referenced this pull requestNov 18, 2024
* Fixes occasional UMM_POISON failureBug introduced with PRfixesp8266#8914.When a reallocated pointer could not grow in place, a replacementallocation was created. Then UMM_POISON was written to the wrong block.* Fix umm_poison data corruption on realloc when memory move is used.Bug introduced with PRfixesp8266#8914* refactored to resolve unused error in some build contexts
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
The umm_poison logic runs outside the UMM_CRITICAL_* umbrella. When interrupt routines do alloc calls, it is possible to interrupt an in-progress allocation just before the poison is set, with a new alloc request resulting in a false "poison check fail" against the in-progress allocation. The SDK does mallocs from ISRs. SmartConfig can illustrate this issue.
This shouldresolve#3494 (comment)
Other Sketches built with Debug: "Serial," that use the SDK's Promiscuous callbacks are also likely to encounter problems.
The SDK support for "Promiscuous Receive" allocates memory from an ISR context, occasionally interrupting the poison wrapper code before it finishes setting the poison fences resulting in afalse poison failed event.
Edited: expanded description