- Notifications
You must be signed in to change notification settings - Fork13.3k
Fix File::readString to work with binary data#8742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Previously, File::readString used a C-style string as an intermediatebuffer via the String += operator. This treats a NUL byte as aterminator, making this function work incorrectly if the File containsbinary data.This commit switches the function to use String::concat, which doesn'ttreat NUL bytes any differently (and is a bit faster, because it doesn'tneed to use strlen).
hasenradball pushed a commit to hasenradball/Arduino that referenced this pull requestNov 18, 2024
Previously, File::readString used a C-style string as an intermediatebuffer via the String += operator. This treats a NUL byte as aterminator, making this function work incorrectly if the File containsbinary data.This commit switches the function to use String::concat, which doesn'ttreat NUL bytes any differently (and is a bit faster, because it doesn'tneed to use strlen).
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, File::readString used a C-style string as an intermediate buffer via the String += operator. This treats a NUL byte as a terminator, making this function work incorrectly if the File contains binary data.
This commit switches the function to use String::concat, which doesn't treat NUL bytes any differently (and is a bit faster, because it doesn't need to use strlen).