Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

boards.txt.py: add Wemos ESP-WROOM-02 board#8664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mcspr merged 3 commits intoesp8266:masterfromrotulet:fix/add_d1_wroom_02
Oct 31, 2022

Conversation

@rotulet
Copy link
Contributor

Get fixes from#6551 (comment)

@mcspr
Copy link
Collaborator

mcspr commentedSep 1, 2022
edited
Loading

Is it really a wemos board?
Shouldn't this bejust esp wroom-02?

@rotulet
Copy link
ContributorAuthor

@mcspr good question! I have got the "official" Wemos logo on it. In many places on internet I found the same board branded Wemos but also clones. But I did not find any references on the Wemos web site!

@rotulet
Copy link
ContributorAuthor

@AronHetLam Sorry but I do not understand what is the error? Can you explain please?

@AronHetLam
Copy link

AronHetLam commentedOct 9, 2022
edited
Loading

@rotulet, I'm not sure what exactly you are unsure about, but I'll explain the problem i had.
When I ran the script for the ESP-wroom-02 board i got an exception because there was no entry in the macros dict forflashfreq_26. Adding it, as you've done one the fix you pushed, fixed the issue for me, and i was able to generate a boards.txt with the entries needed for ESP-wroom-02.
I ran the scrip as standalone, and didn't look to deep into how it's all put together. As you can see in the issue I referenced this issue from, I had someone with a ESP-wroom-02 board that couldn't get my code compiled correctly.

@mcspr
Copy link
Collaborator

Simply run the boards script and commit changes to boards.txt and documentation.

Our Check expects that we have the same filesystem contents before and after running it
https://github.com/esp8266/Arduino/actions/runs/3099983428/jobs/5202829401
(unfold the crossed out section, it shows a git-diff output of what boards.txt.py generated and what changed in the repo)

@rotuletrotuletforce-pushed thefix/add_d1_wroom_02 branch 3 times, most recently from54af6a2 todcdc3a7CompareOctober 31, 2022 17:27
@rotulet
Copy link
ContributorAuthor

Sorry for the delay...

Thanks@mcspr for the hint!

@AronHetLam I updated the board.txt file and rebased on master.

mcspr reacted with hooray emoji

@mcsprmcspr merged commit78444a5 intoesp8266:masterOct 31, 2022
hasenradball pushed a commit to hasenradball/Arduino that referenced this pull requestNov 18, 2024
* add fixes fromesp8266#6551 (comment)* add flashfreq_26 to the macro list
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@AronHetLamAronHetLamAronHetLam left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rotulet@mcspr@AronHetLam

[8]ページ先頭

©2009-2025 Movatter.jp