NotificationsYou must be signed in to change notification settings
Fork13.3k
Star16.5k

Fix hostname management#8626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

d-a-v merged 7 commits intoesp8266:masterfromd-a-v:hostname

Jul 6, 2022

Merged

Fix hostname management#8626

d-a-v merged 7 commits intoesp8266:masterfromd-a-v:hostname

Jul 6, 2022

Conversation

Copy link

Collaborator

d-a-v commentedJul 4, 2022

This proposal addresses two issues

Ethernet hostname change was not working as intended because hostname management relies on wifi_station_set_hostname() and STA can be down when ethernet is used,
Since WiFi is off at boot time, for the same reason, hostname can't be changed until STA is up.

For both issue, solution is to play with hostname location in ram, reserved by SDK, and filled withESP-baffed when WiFi boots but which can be now overwritten back when user had already set it to something.

fixes#8143

d-a-v added2 commits

July 4, 2022 22:24

manage hostname with sdk string

154a41b

comments

9b46278

Copy link

Collaborator

mcspr commentedJul 5, 2022

Running the example from Matrix, everything works correctly.

Is the idea to allow to set netif->hostname later on, or it will stay global hostname setting?
And I guess, replacing SDK approach by removing wifi_station_... func from the SDK blobs, and using our own func setting netif->hostname?

fix emulation on host

352382d

mcspr reviewed

Jul 5, 2022

View reviewed changes

tests/host/common/MockEsp.cpp OutdatedShow resolvedHide resolved

d-a-v added2 commits

July 5, 2022 21:22

remove duplicate hostname per review

e28c404

restyle

a5471e8

Copy link

CollaboratorAuthor

d-a-v commentedJul 5, 2022

Is the idea to allow to set netif->hostname later on, or it will stay global hostname setting?

Both are possible, I think keeping a common global name is better.
Like when you log in a computer with several network cards (ethernet, wifi) or a router: It's much easier when a single name designates a single place.

And I guess, replacing SDK approach by removing wifi_station_... func from the SDK blobs, and using our own func setting netif->hostname?

This is an interesting idea. For now I believe a sketch using the arduino API won't link these functions in.
We can open a new issue for core v4 about that.

Running the example from Matrix, everything works correctly.

Which matrix is it ?

d-a-v added2 commits

July 5, 2022 21:43

wifi_station_hostname is a pointer, not an array

f9b2ab1

simplify

f417a23

Copy link

Collaborator

mcspr commentedJul 6, 2022

Which matrix is it ?

Capital M one! Where you said it would be enough to check ./libraries/ESP8266WiFi/examples/IPv6/IPv6.ino example 🤷

This is an interesting idea. For now I believe a sketch using the arduino API won't link these functions in.
We can open a new issue for core v4 about that.

True, but it's the same issue as with dhcps funcs - NONOS SDK api stops working / interferes with the existing code. SDK part could also be--weaken-symbol=symbolname'd with the objcopy script, and we could have{get,set}hostname() doing this global setting. I will stop theorizing now as well, until the ethernet part works as intended on all fronts :)