Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

do not call tcp/udp ::stopAll() when it is not required to do so#8598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
d-a-v merged 3 commits intoesp8266:masterfromd-a-v:nostopall
Jun 23, 2022

Conversation

@d-a-v
Copy link
Collaborator

fixes#6123

@mcspr
Copy link
Collaborator

ArduinoOTA as well? Even a failed update kills every client
Also note of WebUpdate example

Continuing the idea,UpdaterClass should probably handle that

//This callback will be called when OTA connection has begun
voidonStart(THandlerFunction fn);
//This callback will be called when OTA has finished
voidonEnd(THandlerFunction fn);
//This callback will be called when OTA encountered Error
voidonError(THandlerFunction_Error fn);
//This callback will be called when OTA is receiving data
voidonProgress(THandlerFunction_Progress fn);

Where the user might as well do the

WiFiClient::stopAll();WiFiUDP::stopAll();
// or, where we want some fine grained controlWiFiClient::stopAllExcept(&server.client());WiFiUDP::stopAllExcept(&myPreciousCnC);

@d-a-vd-a-v changed the titledo not call tcp/udp ::stopAll() when it is not required to to sodo not call tcp/udp ::stopAll() when it is not required to do soJun 23, 2022
@d-a-vd-a-v merged commit7d9abbb intoesp8266:masterJun 23, 2022
@d-a-vd-a-v deleted the nostopall branchJune 23, 2022 20:14
@mcsprmcspr mentioned this pull requestJul 30, 2022
mcspr added a commit that referenced this pull requestNov 3, 2022
follow-up of#8598 similar to ArduinoOTA API, execute certain callback in the Updater context.
hasenradball pushed a commit to hasenradball/Arduino that referenced this pull requestNov 18, 2024
…8266#8598)* do not call tcp/udp ::stopAll() when it is not required to to so* remove stopAll also from ArduinoOTA
hasenradball pushed a commit to hasenradball/Arduino that referenced this pull requestNov 18, 2024
follow-up ofesp8266#8598 similar to ArduinoOTA API, execute certain callback in the Updater context.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@mcsprmcsprmcspr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

2 participants

@d-a-v@mcspr
[8]ページ先頭
©2009-2025 Movatter.jp