May 10, 2022 · May 9, 2022 · May 10, 2022 · May 9, 2022 · May 9, 2022 · May 9, 2022
diff --git a/libraries/DNSServer/src/DNSServer.cpp b/libraries/DNSServer/src/DNSServer.cpp
 #include "DNSServer.h"
 #include <lwip/def.h>
 #include <Arduino.h>
 #include <memory>

 extern struct rst_info resetInfo;

 #ifdef DEBUG_ESP_PORT
diff --git a/libraries/DNSServer/src/DNSServer.h b/libraries/DNSServer/src/DNSServer.h
 #ifndef DNSServer_h
 #defineDNSServer_h

 #include<memory>
 #include<WiFiUdp.h>

 // #define DEBUG_DNSSERVER
diff --git a/tests/host/common/MockEsp.cpp b/tests/host/common/MockEsp.cpp

 #include <stdlib.h>

 #include <user_interface.h>
 struct rst_info resetInfo;

 unsigned long long operator"" _kHz(unsigned long long x)
 {
    return x * 1000;
Original file line number	Diff line number	Diff line change
Expand Up		@@ -2,7 +2,7 @@
		#include "DNSServer.h"
		#include <lwip/def.h>
		#include <Arduino.h>
		#include <memory>

		extern struct rst_info resetInfo;

		#ifdef DEBUG_ESP_PORT
Expand Down
Original file line number	Diff line number	Diff line change
		@@ -1,5 +1,7 @@
		#ifndef DNSServer_h
		#defineDNSServer_h

		#include<memory>
Copy link Collaborator mcsprMay 9, 2022 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. future-proofing, I tried adding DNSServer/examples/DNSServer to host test script, but I see valgrind error in UDP code 🤷 something to note Copy link Collaborator mcsprMay 9, 2022 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. future-proofing, I tried adding DNSServer/examples/DNSServer to host test script, but I see valgrind error in UDP code 🤷 something to note Copy link Contributor mhightower83May 9, 2022 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Is there a line number to go with that? Copy link Collaborator mcsprMay 10, 2022 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Also mocking. ~DNSServer -> ~WiFiUDP -> UdpContext.disconnect() tries to delete std::map entry, which may or may not be already destroyed (?). Not related to the DNSServer, but to the way UDP is organized there.
		#include<WiFiUdp.h>

		// #define DEBUG_DNSSERVER
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -36,6 +36,9 @@

		#include <stdlib.h>

		#include <user_interface.h>
		struct rst_info resetInfo;

		unsigned long long operator"" _kHz(unsigned long long x)
		{
		return x * 1000;
Expand Down