NotificationsYou must be signed in to change notification settings
Fork13.3k
Star16.5k

emulation on host: fix for latest changes in dnsserver#8559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

mcspr merged 2 commits intoesp8266:masterfromd-a-v:dnserveronhost

May 10, 2022

Merged

emulation on host: fix for latest changes in dnsserver#8559

mcspr merged 2 commits intoesp8266:masterfromd-a-v:dnserveronhost

May 10, 2022

Conversation

Copy link

Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

future-proofing, I tried adding DNSServer/examples/DNSServer to host test script, but I see valgrind error in UDP code 🤷
something to note

libraries/DNSServer/src/DNSServer.h

		#ifndef DNSServer_h
		#defineDNSServer_h

		#include<memory>

Copy link

Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

future-proofing, I tried adding DNSServer/examples/DNSServer to host test script, but I see valgrind error in UDP code 🤷
something to note

Copy link

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Is there a line number to go with that?

Copy link

Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Also mocking. ~DNSServer -> ~WiFiUDP -> UdpContext.disconnect() tries to delete std::map entry, which may or may not be already destroyed (?).
Not related to the DNSServer, but to the way UDP is organized there.

Copy link

CollaboratorAuthor

d-a-v commentedMay 10, 2022

With this change:

--- a/libraries/DNSServer/examples/DNSServer/DNSServer.ino+++ b/libraries/DNSServer/examples/DNSServer/DNSServer.ino@@ -1,5 +1,5 @@-#include <ESP8266WiFi.h> #include <DNSServer.h>+#include <ESP8266WiFi.h> #include <ESP8266WebServer.h>

This happens:

C++ ...libraries/DNSServer/examples/DNSServer/DNSServer.ino.cpp.oIn file included from ./../../libraries/DNSServer/examples/DNSServer//DNSServer.ino:1,                 from ...libraries/DNSServer/examples/DNSServer/DNSServer.ino.cpp:1:../../libraries/DNSServer/src/DNSServer.h:113:10: error: ‘unique_ptr’ in namespace ‘std’ does not name a template type  113 |     std::unique_ptr<DNSS_REQUESTER[]> _que;      |          ^~~~~~~~~~../../libraries/DNSServer/src/DNSServer.h:4:1: note: ‘std::unique_ptr’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?    3 | #include <WiFiUdp.h>  +++ |+#include <memory>    4 |