Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Initialize SoftAP DhcpServer object on demand#8546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
d-a-v merged 21 commits intoesp8266:masterfrommcspr:dhcps-init-tweaks
Jun 1, 2022

Conversation

@mcspr
Copy link
Collaborator

Remove dependency on global ctor, and just construct the object when
someone asks us to do it. Only dependency right now is netif_git, which
is expected to be initialized by the lwip code some time before
dhcps_start happens.

Removing ip_info from begin(), since we never reference later on.
Also removing the specific check for netif id and simplify the ctors.
Fixing _netif->state check left over from the old code.

Update tests and recover old nonos-sdk dhcps functions that were not implemented.

resolve#7871
resolve#8307
resolve#8471

Remove dependency on global ctor, and just construct the object whensomeone asks us to do it. Only dependency right now is netif_git, whichis expected to be initialized by the lwip code some time beforedhcps_start happens.Removing ip_info from begin(), since we never reference later on.Also removing the specific check for netif id and simplify the ctors.Update tests and recover old nonos-sdk dhcps functions that were not implemented.
Copy link
Collaborator

@d-a-vd-a-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!

@d-a-vd-a-v merged commit502d946 intoesp8266:masterJun 1, 2022
@mcsprmcspr deleted the dhcps-init-tweaks branchJanuary 7, 2023 00:18
vidplace7 added a commit to vidplace7/esphome that referenced this pull requestJan 16, 2023
Behaviour changed in upstream "Initialize SoftAP DhcpServer object on demand"esp8266/Arduino#8546
hasenradball pushed a commit to hasenradball/Arduino that referenced this pull requestNov 18, 2024
* Initialize SoftAP DhcpServer object on demandRemove dependency on global ctor, and just construct the object whensomeone asks us to do it. Only dependency right now is netif_git, whichis expected to be initialized by the lwip code some time beforedhcps_start happens.Removing ip_info from begin(), since we never reference later on.Also removing the specific check for netif id and simplify the ctors.Update tests and recover old nonos-sdk dhcps functions that were not implemented.* nonos helpers have a separate header* wifi ap needs this anyway, simplify sketch includes* missing example* existing name :/* trying to fix header dependency* restyle* not a c header* no need to init* move dhcp server getter to WiFimore... arduino'ish? we ahve object as namespace, plus everything elserelated to softAP is thereredundant includes, redundant mock impl (out-of-scope here to fix)* ...move things back, still expose as WiFi method* review fix* include -nonos header in wifi lib though* no more lwip include* style* need mock dhcpserver instance
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@d-a-vd-a-vd-a-v approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

2 participants

@mcspr@d-a-v

[8]ページ先頭

©2009-2025 Movatter.jp