Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix reuse for different URIs in HTTPClient::begin#8466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
d-a-v merged 2 commits intoesp8266:masterfrompaulocsanz:http-client-begin
Mar 30, 2022
Merged

Fix reuse for different URIs in HTTPClient::begin#8466

d-a-v merged 2 commits intoesp8266:masterfrompaulocsanz:http-client-begin
Mar 30, 2022

Conversation

@paulocsanz
Copy link
Contributor

Fixes#8331

The problem is that_canReuse was not reset in begin, like inHTTPClient::setURL.

Ideally begin should not be called twice if the client hasn't changed, but it may happen, better safe than sorry.

@paulocsanzpaulocsanz changed the titleFix reuse for different URIs in HTTPClient::beginDraft: Fix reuse for different URIs in HTTPClient::beginJan 28, 2022
@d-a-vd-a-v added the alphaincluded in alpha release labelJan 29, 2022
Copy link
Collaborator

@d-a-vd-a-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good!

@d-a-vd-a-v added this to the3.1 milestoneMar 29, 2022
@paulocsanzpaulocsanz changed the titleDraft: Fix reuse for different URIs in HTTPClient::beginFix reuse for different URIs in HTTPClient::beginMar 30, 2022
@paulocsanz
Copy link
ContributorAuthor

paulocsanz commentedMar 30, 2022•
edited
Loading

Let's merge this then! I haven't had time to test this deeply and it doesn't seem to fix all problems from the issue, but it's probably useful the way it is. I removed the draft tag.

@d-a-vd-a-v merged commit32939c4 intoesp8266:masterMar 30, 2022
hasenradball pushed a commit to hasenradball/Arduino that referenced this pull requestNov 18, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@d-a-vd-a-vd-a-v approved these changes

+1 more reviewer

@TD-erTD-erTD-er left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

alphaincluded in alpha release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ESP8266 HTTPClient cannot be reused to connect to a second, different host

4 participants

@paulocsanz@TD-er@d-a-v@earlephilhower
[8]ページ先頭
©2009-2025 Movatter.jp