- Notifications
You must be signed in to change notification settings - Fork13.3k
Heap init code improvements and updates#8458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Moved secondary heap init code to flash. External -24 IRAM, +32 IROM IRAM -76 IRAM, +64 IROMGeneral updates to umm_init call path and DEFINES to better align withupstream. Name changes: UMM_INIT_HEAP with UMM_CHECK_INITIALIZED,umm_init_stage_2 with _umm_init_heap, and umm_init_common with umm_init_heap.Add file umm_cfgport.h to hold port-specific values. Stay focusedon heap initialization only move-related defines.Improved comments.Created a wrapper function for running pre-SDK code from flash.Updated hwdt_app_entry to use it.Update umm_init with option to run from ICACHE.Added build define UMM_INIT_USE_ICACHE to move umm_init call path to flash.When used frees up 160 bytes of IRAM at a cost of 208 bytes of IROMDefaults to no change, umm_init call path will be in IRAM.
d-a-v commentedJan 25, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Would it be more efficient tochange default settings ? Other than that, LGTM and thanks ! |
mhightower83 commentedJan 25, 2022
@d-a-v I was being over-cautious. The experience we have with using switching cache on and off before the SDK initializes is with HWDT Stack Dump, which for me has worked fine without issue. I don't know how often it gets used. I also used it in one of the methods in my "ideas for config erase" PR. So I played it safe and left it as an option to turn on. Hmm, if we have a while before the next dot release and you guys feel comfortable with the change, I could switch the default around? |
d-a-v commentedJan 28, 2022
We think it is OK to go this way ! |
…to UMM_INIT_USE_IRAM.
d-a-v left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks!
* Heap init code improvements and updatesMoved secondary heap init code to flash. External -24 IRAM, +32 IROM IRAM -76 IRAM, +64 IROMGeneral updates to umm_init call path and DEFINES to better align withupstream. Name changes: UMM_INIT_HEAP with UMM_CHECK_INITIALIZED,umm_init_stage_2 with _umm_init_heap, and umm_init_common with umm_init_heap.Add file umm_cfgport.h to hold port-specific values. Stay focusedon heap initialization only move-related defines.Improved comments.Created a wrapper function for running pre-SDK code from flash.Updated hwdt_app_entry to use it.Update umm_init with option to run from ICACHE.Added build define UMM_INIT_USE_ICACHE to move umm_init call path to flash.When used frees up 160 bytes of IRAM at a cost of 208 bytes of IROMDefaults to no change, umm_init call path will be in IRAM.* Changed default to use IROM for umm_init() and option to revert back to UMM_INIT_USE_IRAM.
Uh oh!
There was an error while loading.Please reload this page.
Moved secondary heap init code to flash.
General updates to
umm_initcall path and defines to better align with upstream. Name changes:UMM_INIT_HEAPwithUMM_CHECK_INITIALIZED,umm_init_stage_2with_umm_init_heap, andumm_init_commonwithumm_init_heap.Add file
umm_cfgport.h to hold port-specific values. Stay focused on heap initialization only move-related defines.Improved comments.
Created a wrapper function for running pre-SDK code from flash.
Updated
hwdt_app_entryto use it.Update
umm_initwith the option to run from ICACHE.Added build defineUMM_INIT_USE_ICACHEto moveumm_initcall path to flash.Added build define
UMM_INIT_USE_IRAMto moveumm_initcall path back to IRAM.Using ICACHE frees up 160 bytes of IRAM at a cost of 208 bytes of IROM.
Defaults to no change,umm_initcall path will be in IRAM.Defaults with
umm_initcall path in ICACHE.