- Notifications
You must be signed in to change notification settings - Fork13.3k
import getLocalTime() from esp32/Arduino#8413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
cores/esp8266/timehelper.cpp Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This might better be put into the existingtime.cpp file instead of making a new one.
Also, a new file would need the GPL headers/etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This might better be put into the existing time.cpp file instead of making a new one.
time.cpp is not compiled in host mode. This new file would.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The function is now intime.cpp, the other new file is removed.
earlephilhower left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM!
* import getLocalTime() from esp32/Arduinofollowsesp8266#8407
follows andcloses#8407