- Notifications
You must be signed in to change notification settings - Fork13.3k
Backported getLocalTime from ESP32 Arduino#8407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
d-a-v commentedDec 14, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
It seems that you have to rename |
h1aji commentedDec 15, 2021
the only part that appears different is - I assume we can modify
getLocalTime(&tmstruct, 500);then deletegetLocalTime from that sketch @earlephilhower what do you think? |
h1aji commentedDec 16, 2021
@d-a-v does this look ok now? |
cores/esp8266/time.cpp Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
With this loop, maximum timeout is 10 times the value ofms, which is why Earle divided it by 10.
Original and probably later updated / fixed esp32 codeis there with a more accurate loop.
Do you think you can improve your proposal ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Okay then, do you have an idea how LittleFS_Timestamp.ino sketch should be modified?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think it is OK to use the esp32 implementation globally and remove littlefs test's one.
d-a-v commentedDec 16, 2021
About the CI error, |
h1aji commentedDec 16, 2021
It looks like this PR causing lots of troubles. Shall I close it? |
d-a-v commentedDec 16, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
No :) if you want to do it. (please tell if you only need the feature without adding it yourself) |
h1aji commentedDec 16, 2021
I dont mind if you add it yourself, otherwise I am happy with this commit, I wasnt sure how to change that sketch file, that why i though asking you |
d-a-v commentedDec 16, 2021
I used updated esp32 code in#8413, moved the function into another file so it can be used for the esp8266, emulation on host, and host tests, and removed the old local copy from the littleFS test. You can get inspiration from it to fix the CI builds if you like. |
h1aji commentedDec 17, 2021
@d-a-v nice. tthank you. |
* import getLocalTime() from esp32/Arduinofollows#8407
* import getLocalTime() from esp32/Arduinofollowsesp8266#8407
New PR. Removed previosly added modifications.
This time just importing new getLocalTime from ESP32 Arduino core