- Notifications
You must be signed in to change notification settings - Fork13.3k
Adding custom buffer_length using I2C_BUFFER_LENGTH#8390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
d-a-v left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Approving.
As mentioned in the other closed PR, rx/txBufferIndex and rx/txBufferLength should be made into 16 or 32 bits. I guess this will be for another PR.
d-a-v commentedNov 28, 2021
If you are running with linux or wsl2, there's the |
Maelstrom96 commentedNov 29, 2021
The style should match what it's expecting now - Also merged changes from master. |
Maelstrom96 commentedDec 1, 2021
Missing anything in order for this to get merged? |
* Adding custom buffer_length using I2C_BUFFER_LENGTH
New PR that expands on#8388.
Changed it so it's the same setting name (
I2C_BUFFER_LENGTH) on both ESP8266 and ESP32 Wire library.