- Notifications
You must be signed in to change notification settings - Fork13.3k
call umm_init just before starting SDK#8207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Keep Basic ASM version of app_entry_redefinable and removed alternate"C"/Extended ASM version. Update comments.
d-a-v left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM.
I understand it is a bugfix that should be merged now, right ?
mhightower83 commentedJul 18, 2021
@d-a-v - Yes this is a bug fix ready for merge. I also added a few missing comments, removed an unused build path, and updated the example code to make the zeros more evident should they return. |
earlephilhower left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
This fixes a problem I saw on a post to esp8266/arduino 👉 :June 30, 2021 11:40 AM, where the BearSSL stack trace is all zero's after an HWDT. I was too slow to recognize I had a problem around the time of his post.
The problem was
umm_initwas being done too early and the Heap was zeroed out before the stack dump was performed.Added code to HWDT example to use StackThunk. This should make the problem more visible in the future should it return.