- Notifications
You must be signed in to change notification settings - Fork13.3k
github action: enforce issue detection with bash#8168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| run:| | ||
| # Sets an environment variable used in the next steps | ||
| echo "TRAVIS_TAG=$(git describe --exact-match --tags)" >> $GITHUB_ENV | ||
| TRAVIS_TAG=$(git describe --exact-match --tags)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| TRAVIS_TAG=$(git describe --exact-match --tags)" | |
| TRAVIS_TAG=$(git describe --exact-match --tags) |
(I typed this wrong)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for reviewing (I didn't make a copy-paste, It's simply that I made the same mistake)
earlephilhower left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Silly GH CI bug, good catch.
Per discussion with@mcspr.
When not specifiying
bashas running shell, default options do not include-o pipefailas it should.It may not prevent a script to stop when one component of a pipe chain fails (ex:
false | truewon't fail but it should).As a consequence in this PR,
bashisexplicitely specified as default shell.Also enforcing issue detection by breaking down commands
echo "$(command)" >> file=>var=$(command)thenecho ${var} >> file