This warning is basically a must-have on the ESPs. Is there a way to treat it as an error? Because that is what it really is on this architecture, returning from non-void function without a return statement.@earlephilhower That said, then looked at your PR, you have already upgraded it to error, correct? Thanks, this will help me with 3rd party PRs to my libraries as well.

This warning is basically a must-have on the ESPs. Is there a way to treat it as an error? Because that is what it really is on this architecture, returning from non-void function without a return statement.

Notice it is not just -W, but -Werror. Turns out gcc can selectively pick warnings to be treated as errors

@me-no-dev In reference to the now closed discussion aboutespressif/arduino-esp32#5310, would you see any value in this and get it inserted into the right places, instead of the simple warning, that I am already getting for such misuses (warning: no return statement in function returning non-void [-Wreturn-type])?

@dok-net I will accept the same change in the ESP32 repo 😄

@me-no-dev Before moving over there (sorry ESP8266 guys for talking about ESP32 here), you recently said:

all of the changes that you have made are to files that are auto generated by the lib builder. They will not stick. The lib builder get's the flags from IDF's compile process.

The files wereplatform.txt, andtools/platformio-build-esp32*.py.
Predictably, now I am confused, shall I PR a change to these files in the ESP32 repo or not? Mind you, I am not familiar with "the lib builder" or the IDF.

just-Werror=return-type can be added to platform.txt. Nothing else from your previous PR

@earlephilhower This is from ESP32,

compiler.warning_flags.more=-Wall -Werror=allcompiler.warning_flags.all=-Wall -Werror=all -Wextra

What do you think about-Werror=all forflags.more andflags.all, respectively? I can't image there is any difference between ESP8266 and ESP32 that requires this difference? Of course this is before this PR, but I'm just about to duplicate that to ESP32, so I could use some guidance on whether to make this the same.