- Notifications
You must be signed in to change notification settings - Fork13.3k
BREAKING - Use IRAM_ATTR in place of ICACHE_RAM_ATTR#7921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Update the core to use the define that the ESP32 uses, IRAM_ATTR, forplacing code in DRAM.
earlephilhower added a commit to earlephilhower/espsoftwareserial that referenced this pull requestMar 14, 2021
Replace ICACHE_RAM_ATTR with IRAM_ATTR in the few places it was stillpresent, to unify the ESP32 and ESP8266 codepaths. ESP8266 core isdeprecating the ICACHE_RAM_ATTR define in 3.0.0:esp8266/Arduino#7921
CollaboratorAuthor
earlephilhower commentedMar 14, 2021
Waiting onplerup/espsoftwareserial#202 to clear up warnings on SoftwareSerial. |
devyte approved these changesMar 14, 2021
dok-net pushed a commit to plerup/espsoftwareserial that referenced this pull requestMar 14, 2021
Replace ICACHE_RAM_ATTR with IRAM_ATTR in the few places it was stillpresent, to unify the ESP32 and ESP8266 codepaths. ESP8266 core isdeprecating the ICACHE_RAM_ATTR define in 3.0.0:esp8266/Arduino#7921
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the core to use the define that the ESP32 uses, IRAM_ATTR, for
placing code in DRAM.
As discussed privately. Adds a deprecated warning to the old use.