- Notifications
You must be signed in to change notification settings - Fork13.3k
Update toolchain to support std::remainder#7849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Update newlib to enable the __iee745_remainder(f) calls required bystd::remainder and others.Fixesesp8266#7845
mcspr commentedJan 29, 2021
#7845 successfully builds using Windows toolchain, no surprises so far Does this need a test similar to this? Arduino/tests/device/test_sw_newlib/test_sw_newlib.ino Lines 27 to 31 in39d1453
to at least call it once |
earlephilhower commentedJan 29, 2021
Good idea,@mcspr . Since it's in newlib and not the core the chance of it re-breaking is low but I'll throw something in so that it at least checks linkage (the base problem here) once somewhere... |
Update newlib to enable the __ieee754_remainder(f) calls required by
std::remainder and others.
Fixes#7845