The problem w/this PR is thatArduino.h has all its functions asextern "C" which means things like different signatures and default values are not going to compile properly.

Maybe ananalogWriteEx(pin, val, setDrive) and a correspondingdigitalWriteEx(pin, val, setDrive) or something similar would be a better way forward?

The problem w/this PR is that Arduino.h has all its functions as extern "C" which means things like different signatures and default values are not going to compile properly.

Thanks, I just noticed that.

Maybe an analogWriteEx(pin, val, setDrive)

I named it analogWriteMode() but we can rename it to analogWriteEx()

and a corresponding digitalWriteEx(pin, val, setDrive)

I think digitalWrite() does not set pin mode to OUTPUT or does it?

Maybe an analogWriteEx(pin, val, setDrive)
I named it analogWriteMode() but we can rename it to analogWriteEx()

No problem, your name makes sense.

and a corresponding digitalWriteEx(pin, val, setDrive)
I think digitalWrite() does not set pin mode to OUTPUT or does it?

That's correct, my mistake. I just checked upstream, too, and that's the Arduino way.

I just saw that my editor removed a lot of whitespaces indoc/reference.rst and re-added these whitespaces with the last commit... -.-

@klugem you got the spaces thing fixed, but there's now a regression of a submodule, SoftwareSerial.

Easiest thing to do is go to the libraries/SWSerial directory andgit checkout 27477f7 and then go up to the main git repo and redo thegit commit -a to match it to current master. Or, if your git-fu is strong, just remove the SWSerial reference in the patch...

This was caused because I clicked on "Update branch"...I reverted this commit.

@earlephilhower This commit is not OK, despite reviews. What is the intended function on an "open" analogWrite? You can't switch the mode in that case due to the "else":

if (analogMap & 1UL << pin) {  // Per the Arduino docs at https://www.arduino.cc/reference/en/language/functions/analog-io/analogwrite/  // val: the duty cycle: between 0 (always off) and 255 (always on).  // So if val = 0 we have digitalWrite(LOW), if we have val==range we have digitalWrite(HIGH)     analogMap &= ~(1 << pin);  }  else {    if(openDrain) {      pinMode(pin, OUTPUT_OPEN_DRAIN);    } else {      pinMode(pin, OUTPUT);    }  }

Plus, the comment about on and off has drifted far from anything that it might apply to :-)

Give me some hint as to how this should behave and I'll PR a fix.
Edit: I'm sorry, I am not going to give myself another headache and build merge conflicts, so the fix is in PR#8008 /#8011 now.