- Notifications
You must be signed in to change notification settings - Fork13.3k
Fix: cannot build after #7060 on Win64#7754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Fix: cannot build after #7060 on Win64#7754
Uh oh!
There was an error while loading.Please reload this page.
Conversation
d-a-v left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Side note:
if we are ready to create external helpers,
we could use the same scripts written in python for all archs.
* add double-quotes to `compiler.S.flags`* fix windows-specific processes (`recipe.hooks.linking.prelink.[12].pattern.windows`)* rewrite processing of "mkdir" and "cp" in python because of platform-independence
523ec80 toa6f569fComparedok-net commentedDec 13, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Oops, I didn't notice this one... made my own PR#7761 fixing this same problem tonight. Without all that Python overhead, though. I'm surprised why this PR changes so much more than I did. |
…lash* upstream/master: (72 commits) Typo error in ESP8266WiFiGeneric.h (esp8266#7797) lwip2: use pvPortXalloc/vPortFree and "-free -fipa-pta" (esp8266#7793) Use smarter cache key, cache Arduino IDE (esp8266#7791) Update to SdFat 2.0.2, speed SD access (esp8266#7779) BREAKING - Upgrade to upstream newlib 4.0.0 release (esp8266#7708) mock: +hexdump() from debug.cpp (esp8266#7789) more lwIP physical interfaces (esp8266#6680) Rationalize File timestamp callback (esp8266#7785) Update to LittleFS v2.3 (esp8266#7787) WiFiServerSecure: Cache SSL sessions (esp8266#7774) platform.txt: instruct GCC to perform more aggressive optimization (esp8266#7770) LEAmDNS fixes (esp8266#7786) Move uzlib to master branch (esp8266#7782) Update to latest uzlib upstream (esp8266#7776) EspSoftwareSerial bug fix release 6.10.1: preciseDelay() could delay() for extremely long time, if period duration was exceeded on entry. (esp8266#7771) Fixed OOM double count in umm_realloc. (esp8266#7768) Added missing check for failure on umm_push_heap calls in Esp.cpp (esp8266#7767) Fix: cannot build afteresp8266#7060 on Win64 (esp8266#7754) Add the missing 'rename' method wrapper in SD library. (esp8266#7766) i2s: adds i2s_rxtxdrive_begin(enableRx, enableTx, driveRxClocks, driveTxClocks) (esp8266#7748) ...
Uh oh!
There was an error while loading.Please reload this page.
add double-quotes to
compiler.S.flagsfix windows-specific processes (
recipe.hooks.linking.prelink.[12].pattern.windows)rewrite processing of "mkdir" and "cp" in python because of platform-independence
make consistent with the use of quotation marks in other
*.pyfiles